Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vega] add functional tests for Vega visualization #74097

Merged
merged 16 commits into from
Aug 12, 2020
Merged

[Vega] add functional tests for Vega visualization #74097

merged 16 commits into from
Aug 12, 2020

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Aug 3, 2020 •
edited by zube bot
Loading

Part of #21721

Summary

Add function tests for:

  • Inspector panel
    • Request tab
    • Vega Debug tab
  • Vega's extension functions
    • kibanaAddFilter
    • kibanaRemoveFilter
    • kibanaRemoveAllFilters
    • kibanaSetTimeFilter

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@alexwizp
Copy link
Contributor Author

alexwizp commented Aug 5, 2020

@elasticmachine merge upstream

@alexwizp alexwizp marked this pull request as ready for review August 10, 2020 09:35
@alexwizp alexwizp requested a review from a team August 10, 2020 09:35
@alexwizp alexwizp requested a review from a team as a code owner August 10, 2020 09:35
@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@alexwizp alexwizp self-assigned this Aug 10, 2020
@alexwizp alexwizp added Feature:Vega Vega visualizations v8.0.0 labels Aug 10, 2020
@alexwizp alexwizp added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@dmlemeshko
Copy link
Member

I got 2/30 failures with https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/767/

Kibana Pipeline / agent-2 / Chrome UI Functional Tests.test/functional/apps/visualize/_vega_chart·ts.visualize app vega chart in visualize app Vega extension functions should remove all filters by calling "kibanaRemoveAllFilters" expression (from (TEST-job-kibana-ciGroup12-worker-1-Chrome UI Functional Tests.xml))
{ TimeoutError: Waiting for element to be located By(css selector, div.vgaVis__view)
Wait timed out after 10033ms
    at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
    at process._tickCallback (internal/process/next_tick.js:68:7) name: 'TimeoutError', remoteStacktrace: '' }

jobs:kibana+flaky-test-suite-runner:767:flaky-test

@alexwizp please check how it can be improved

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@dmlemeshko dmlemeshko self-requested a review August 12, 2020 10:42
dmlemeshko
dmlemeshko approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.
Flaky test runner 40/40 https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/773/

stratoula
stratoula approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very happy for this PR 🎉

@alexwizp alexwizp merged commit 21b9b36 into elastic:master Aug 12, 2020
@alexwizp alexwizp mentioned this pull request Aug 12, 2020
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request Aug 12, 2020
@alexwizp @elasticmachine
[Vega] add functional tests for Vega visualization (elastic#74097)
bcd8112 
* [Vega] [Inspector] add functional tests for Request tab

* add some tests for Vega Debug tab

* add clipboard permissions for webdriver

* add smoke tests for data grid

* fix CI

* add some tests for vega expression funcitons

* change order

* Update _vega_chart.ts

* Rename dagta_grid.ts to data_grid.ts

* Update index.ts

* Update data_grid.ts

* stabilize tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@timroes timroes mentioned this pull request Aug 12, 2020
Closed
20 tasks
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 12, 2020
@gmmorris
Merge branch 'master' into actions/webhook-remove-header
d500411 
* master:
  [Vega] add functional tests for Vega visualization (elastic#74097)
  [ML] Removing full lodash library imports (elastic#74742)
  [Search] Server strategy example (elastic#71679)
  [Reporting] Fix and test for Listing of Reports (elastic#74453)
  [maps] fix drawing shapes (elastic#74689)
  [Resolver] Improve simulator. Add more click-through tests and panel tests. (elastic#74601)
  Deprecate schema-less specs in Vega (elastic#73805)
  [Security Solution] Rename Administration > Hosts subtab to Endpoints (elastic#74287)
  Timelion deprecation doc (elastic#74508)
alexwizp added a commit that referenced this pull request Aug 12, 2020
@alexwizp @elasticmachine
[Vega] add functional tests for Vega visualization (#74097) (#74843)
32c9e2c 
* [Vega] [Inspector] add functional tests for Request tab

* add some tests for Vega Debug tab

* add clipboard permissions for webdriver

* add smoke tests for data grid

* fix CI

* add some tests for vega expression funcitons

* change order

* Update _vega_chart.ts

* Rename dagta_grid.ts to data_grid.ts

* Update index.ts

* Update data_grid.ts

* stabilize tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 10, 2020 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

‼️ ERROR: metrics for f621b0e were not reported

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@dmlemeshko dmlemeshko dmlemeshko approved these changes

Assignees

@alexwizp alexwizp

Labels
automation Feature:Vega Vega visualizations release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexwizp @elasticmachine @dmlemeshko @kibanamachine @stratoula