[bin/kibana-plugin] support KP plugins instead #74604

spalger · 2020-08-06T21:48:02Z

Related to #56205

The current bin/kibana-plugin CLI only supports installing/managing legacy plugins. This PR updates it to only support Kibana Platform plugins. This change is inline with dropping support for legacy plugin support in 7.10.

Release note:

The bin/kibana-plugin CLI has been updated to work with the new Kibana Platform plugin format instead of the legacy plugin format.

elasticmachine · 2020-08-07T01:48:44Z

Pinging @elastic/kibana-operations (Team:Operations)

spalger · 2020-08-10T15:57:10Z

@elasticmachine merge upstream

…-plugin-installer-support

…palger/kibana into remove/legacy-plugin-installer-support

kibanamachine · 2020-08-11T17:00:52Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: a96979f

Build metrics

page load bundle size

id	value	diff	baseline
upgradeAssistant	65.2KB	-36.0B	65.2KB

History

💚 Build #67293 succeeded 3e77328
💚 Build #67075 succeeded 1decf87
💔 Build #67070 failed 7e72fde

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

joshdover

Tested locally without any issues 👍 Thanks for the help here!

joshdover · 2020-08-12T22:00:27Z

src/cli_plugin/install/zip.js

+              kibanaVersion:
+                typeof manifest.kibanaVersion === 'string' && manifest.kibanaVersion
+                  ? manifest.kibanaVersion
+                  : manifest.version,


I think we should only use the kibanaVersion key and ignore the plugin version. I'd prefer we err on the side of explicitness here and force plugins to declare their intention. If kibanaVersion is not specified, we should throw an error.

We should also adjust the logic in here in Core to match. This could be done as a follow up.

Yeah, I based this logic off of that logic but I welcome that change as a follow up.

joshdover · 2020-08-12T22:03:57Z

src/cli_plugin/install/zip.js

+
+            plugins.push({
+              id: manifest.id,
+              stripPrefix: match[1],


Why the change from archivePath to stripPrefix? I think the old name was clearer

Mostly because archivePath sounds like the location of an archive to me, and as far as I can tell this was used for one thing: stripping a prefix from the paths before writing them to disk. I personally like the new name better.

joshdover · 2020-08-12T22:05:08Z

src/cli_plugin/lib/error_if_x_pack.js

@@ -17,15 +17,15 @@
 * under the License.
 */

-import { isOSS } from './is_oss';
+import { isOss } from './is_oss';

 function isXPack(plugin) {
  return /x-pack/.test(plugin);
 }

 export function errorIfXPackInstall(settings) {


Do we even need any of this logic anymore? X-Pack cannot be installed or removed from a distributable

Yeah, that's what this logic is intended for. If someone tries to install x-pack this logic will help people know they should download the default distributable.

mistic

LGTM 🎉

* [cli/kibana-plugin] support KP plugins instead * fix some Logger imports from cli/kibana_keystore Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # packages/kbn-pm/dist/index.js

Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (28 commits) [Task manager] Prevents edge case where already running tasks are reschedule every polling interval (elastic#74606) [Security Solution] Fix the status of timelines' bulk actions (elastic#74560) Data plugin: Suggested enhance pattern (elastic#74505) Use jest.useFakeTimers instead of hard coded timeout for tooltip tests. (elastic#74642) [Security Solution][lists] Adds tests for exception lists and items part 2 (elastic#74815) [Security Solution][Resolver] fix presentation role on edgeline (elastic#74869) [Security Solution][Detections] Refactor ML calls for newest ML permissions (elastic#74582) [bin/kibana-plugin] support KP plugins instead (elastic#74604) Reduce number of indexed fields in index pattern saved object (elastic#74817) [reporting] Pass along generic parameters in high-order route handler (elastic#74892) Migrated last pieces of legacy fixture code (elastic#74470) Empty index patterns page re-design (elastic#68819) [babel] coalese some versions to prevent breaking yarn install (elastic#74864) [Dashboard First] Decouple Attribute Service and By Value Embeddables (elastic#74302) Revert "[reporting] Pass along generic parameters in high-order route handler" (elastic#74891) [reporting] Pass along generic parameters in high-order route handler (elastic#74879) [src/dev/build] implement a getBuildNumber() mock (elastic#74881) [Enterprise Search] Add solution-level side navigation (elastic#74705) [DOCS] Canvas docs 7.9 refresh (elastic#74000) [Security Solution][Resolver]Enzyme test related events closing (elastic#74811) ...

…le-buffer-with-update-of-same-id * upstream/master: (37 commits) [Task manager] Prevents edge case where already running tasks are reschedule every polling interval (elastic#74606) [Security Solution] Fix the status of timelines' bulk actions (elastic#74560) Data plugin: Suggested enhance pattern (elastic#74505) Use jest.useFakeTimers instead of hard coded timeout for tooltip tests. (elastic#74642) [Security Solution][lists] Adds tests for exception lists and items part 2 (elastic#74815) [Security Solution][Resolver] fix presentation role on edgeline (elastic#74869) [Security Solution][Detections] Refactor ML calls for newest ML permissions (elastic#74582) [bin/kibana-plugin] support KP plugins instead (elastic#74604) Reduce number of indexed fields in index pattern saved object (elastic#74817) [reporting] Pass along generic parameters in high-order route handler (elastic#74892) Migrated last pieces of legacy fixture code (elastic#74470) Empty index patterns page re-design (elastic#68819) [babel] coalese some versions to prevent breaking yarn install (elastic#74864) [Dashboard First] Decouple Attribute Service and By Value Embeddables (elastic#74302) Revert "[reporting] Pass along generic parameters in high-order route handler" (elastic#74891) [reporting] Pass along generic parameters in high-order route handler (elastic#74879) [src/dev/build] implement a getBuildNumber() mock (elastic#74881) [Enterprise Search] Add solution-level side navigation (elastic#74705) [DOCS] Canvas docs 7.9 refresh (elastic#74000) [Security Solution][Resolver]Enzyme test related events closing (elastic#74811) ...

* upstream/master: (45 commits) [Metrics UI] Fix inventory footer misalignment (elastic#74707) Remove legacy optimizer (elastic#73154) Update design-specific GH code-owners (elastic#74877) skip test Reporting paginates content elastic#74922 [Metrics UI] Add Jest tests for alert previews (elastic#74890) Fixed tooltip (elastic#74074) [Ingest Pipelines] Processor forms for processors A-D (elastic#72849) [Observability] change ingest manager link (elastic#74928) [Task manager] Prevents edge case where already running tasks are reschedule every polling interval (elastic#74606) [Security Solution] Fix the status of timelines' bulk actions (elastic#74560) Data plugin: Suggested enhance pattern (elastic#74505) Use jest.useFakeTimers instead of hard coded timeout for tooltip tests. (elastic#74642) [Security Solution][lists] Adds tests for exception lists and items part 2 (elastic#74815) [Security Solution][Resolver] fix presentation role on edgeline (elastic#74869) [Security Solution][Detections] Refactor ML calls for newest ML permissions (elastic#74582) [bin/kibana-plugin] support KP plugins instead (elastic#74604) Reduce number of indexed fields in index pattern saved object (elastic#74817) [reporting] Pass along generic parameters in high-order route handler (elastic#74892) Migrated last pieces of legacy fixture code (elastic#74470) Empty index patterns page re-design (elastic#68819) ...

[cli/kibana-plugin] support KP plugins instead

7e72fde

spalger added release_note:breaking Team:Operations Team label for Operations Team v8.0.0 v7.10.0 labels Aug 6, 2020

spalger changed the title ~~[cli/kibana-plugin] support KP plugins instead~~ [bin/kibana-plugin] support KP plugins instead Aug 6, 2020

fix some Logger imports from cli/kibana_keystore

1decf87

spalger marked this pull request as ready for review August 7, 2020 01:48

spalger requested a review from a team as a code owner August 7, 2020 01:48

spalger requested a review from a team August 7, 2020 01:48

elasticmachine and others added 3 commits August 10, 2020 09:57

Merge branch 'master' into remove/legacy-plugin-installer-support

3e77328

Merge branch 'master' of github.com:elastic/kibana into remove/legacy…

c491f31

…-plugin-installer-support

Merge branch 'remove/legacy-plugin-installer-support' of github.com:s…

a96979f

…palger/kibana into remove/legacy-plugin-installer-support

joshdover approved these changes Aug 12, 2020

View reviewed changes

mistic approved these changes Aug 12, 2020

View reviewed changes

spalger merged commit a735a9f into elastic:master Aug 12, 2020

spalger deleted the remove/legacy-plugin-installer-support branch August 12, 2020 23:38

spalger mentioned this pull request Aug 12, 2020

[7.x] [bin/kibana-plugin] support KP plugins instead (#74604) #74917

Merged

spalger added a commit that referenced this pull request Aug 13, 2020

[7.x] [bin/kibana-plugin] support KP plugins instead (#74604) (#74917)

e517adc

Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

spalger mentioned this pull request Aug 14, 2020

[cli/plugins] plugin installation format requirement and errors #74909

Open

joshdover mentioned this pull request Aug 19, 2020

Make src/cli_plugin compatible with Platform plugins #56482

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[bin/kibana-plugin] support KP plugins instead #74604

[bin/kibana-plugin] support KP plugins instead #74604

spalger commented Aug 6, 2020 •

edited

Loading

elasticmachine commented Aug 7, 2020

spalger commented Aug 10, 2020

kibanamachine commented Aug 11, 2020

joshdover left a comment

joshdover Aug 12, 2020

spalger Aug 12, 2020

joshdover Aug 12, 2020

spalger Aug 12, 2020

joshdover Aug 12, 2020

spalger Aug 12, 2020 •

edited

Loading

mistic left a comment

[bin/kibana-plugin] support KP plugins instead #74604

[bin/kibana-plugin] support KP plugins instead #74604

Conversation

spalger commented Aug 6, 2020 • edited Loading

elasticmachine commented Aug 7, 2020

spalger commented Aug 10, 2020

kibanamachine commented Aug 11, 2020

💚 Build Succeeded

Build metrics

page load bundle size

History

joshdover left a comment

Choose a reason for hiding this comment

joshdover Aug 12, 2020

Choose a reason for hiding this comment

spalger Aug 12, 2020

Choose a reason for hiding this comment

joshdover Aug 12, 2020

Choose a reason for hiding this comment

spalger Aug 12, 2020

Choose a reason for hiding this comment

joshdover Aug 12, 2020

Choose a reason for hiding this comment

spalger Aug 12, 2020 • edited Loading

Choose a reason for hiding this comment

mistic left a comment

Choose a reason for hiding this comment

spalger commented Aug 6, 2020 •

edited

Loading

spalger Aug 12, 2020 •

edited

Loading