Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Singular alert #74659

Merged
merged 13 commits into from
Aug 14, 2020
Merged

[Uptime] Singular alert #74659

merged 13 commits into from
Aug 14, 2020

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Aug 10, 2020

Summary

Fixes: elastic/uptime#237

This PR changes the default behaviour of monitor status alert from a digest type message to message per monitor per location.

Down check default message:

Monitor HTTP-NOWHERE with url http://nowhere.example.com is down from nyc-heartbeat. The latest error message is lookup nowhere.example.com on 10.55.240.10:53: no such host

Availability check default message:

Monitor Always Down Local Port with url tcp://localhost:18278 is below threshold with 0.00% availability expected is 99% from nyc-heartbeat. The latest error message is dial tcp 127.0.0.1:18278: connect: connection refused

Message where both down and availability check are enabled

Monitor tcp-ext-KIBANA with url tcp://kibana.35.241.204.195.ip.es.io:443 is down and also below threshold with 28.37% availability expected is 99% from nyc-heartbeat. The latest error message is dial tcp 35.241.204.195:443: i/o timeout

in Alert Flyout message will appear like this

image

user can change message at will by selecting from following monitor fields monitorId, monitorUrl, monitorType, latestErrorMessage, observerLocation, observerHostname, statusMessage

image

Alerts pre 7.10 will continue to work but their behaviour will change instead of throwing a combined message, user will receive a singular message as well.

image

@shahzad31 shahzad31 marked this pull request as ready for review August 10, 2020 21:22
@shahzad31 shahzad31 requested a review from a team as a code owner August 10, 2020 21:22
@shahzad31 shahzad31 self-assigned this Aug 10, 2020
@shahzad31 shahzad31 added release_note:enhancement Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.10.0 v8.0.0 labels Aug 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
uptime 1.6MB +1.8KB 1.6MB

page load bundle size

id value diff baseline
uptime 25.0KB +1.1KB 23.9KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here, left a comment about inheritance vs pseudo-inheritance via composition

Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested this locally and it's working as I'd expect, and it's a better alerting experience getting a per-monitor notification.

@shahzad31 shahzad31 merged commit 7cf0e49 into elastic:master Aug 14, 2020
@shahzad31 shahzad31 deleted the singular-alert branch August 14, 2020 07:45
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 14, 2020
* master: (23 commits)
  Adding API test for custom link transaction example (elastic#74238)
  [Uptime] Singular alert (elastic#74659)
  Revert "attempt excluding a codeowners directory" (elastic#75023)
  [Metrics UI] Remove TSVB dependency from Metrics Explorer APIs (elastic#74804)
  Remove degraded state from ES status service (elastic#75007)
  [Reporting/Functional] unskip pagination test (elastic#74973)
  [Resolver] Stale query string values are removed when resolver's component instance ID changes. (elastic#74979)
  Add public url to Workplace Search plugin (elastic#74991)
  [Reporting] Update more Server Types for TaskManager (elastic#74915)
  [I18n] verify select icu-message options are in english (elastic#74963)
  Make data.search.aggs available on the server. (elastic#74472)
  [Security Solution][Resolver] Graph Control Tests and Update Simulator Selectors (elastic#74680)
  attempt excluding a codeowners directory
  [ML] DF Analytics: allow failed job to be stopped by force via the UI (elastic#74710)
  Add kibana-core-ui-designers team (elastic#74970)
  [Metrics UI] Fix inventory footer misalignment (elastic#74707)
  Remove legacy optimizer (elastic#73154)
  Update design-specific GH code-owners (elastic#74877)
  skip test Reporting paginates content elastic#74922
  [Metrics UI] Add Jest tests for alert previews (elastic#74890)
  ...
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Aug 14, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mikecote pushed a commit that referenced this pull request Aug 14, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:enhancement Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simple, Singular Monitor Alerts
5 participants