Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Functional Tests] Adds a wait time between setting the index pattern and the time field on TSVB #74736

Merged
merged 4 commits into from
Aug 11, 2020
Merged

[Functional Tests] Adds a wait time between setting the index pattern and the time field on TSVB #74736

merged 4 commits into from
Aug 11, 2020

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Aug 11, 2020 •
edited
Loading

Summary

Fixes #71979 and #44132.

The flakiness was caused because the index pattern is set very quickly, and for that reason, the time field has zero options. In order to give some time to the Time Field dropdown to load its options, I have introduced a sleep of 3sec between setting the index pattern and setting the time field as also I type the index pattern char by char.

Flaky test runner (100 times): https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/771/
I have also run it on cloud, it doesn't seem flaky there too

Checklist

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula marked this pull request as ready for review August 11, 2020 14:24
@stratoula stratoula requested a review from dmlemeshko August 11, 2020 14:24
@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0 failed-test A test failure on a tracked branch, potentially flaky-test labels Aug 11, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-test-triage (failed-test)

@stratoula stratoula added the Feature:TSVB TSVB (Time Series Visual Builder) label Aug 11, 2020
dmlemeshko
dmlemeshko approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Let's see how it goes 🙌

@stratoula stratoula merged commit 78689b7 into elastic:master Aug 11, 2020
stratoula added a commit to stratoula/kibana that referenced this pull request Aug 11, 2020
@stratoula
[Functional Tests] Adds a wait time between setting the index pattern…
c707883 
… and the time field on TSVB (elastic#74736)

* Adds a wait time between setting the index pattern and the time field on tsvb

* Char by char to set indexpattern to give more time to load the time field

* Add more time

* uncomment commented lines
@stratoula stratoula mentioned this pull request Aug 11, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 11, 2020
@gmmorris
Merge branch 'master' into actions/webhook-remove-header
1dbf2f2 
* master: (106 commits)
  [Functional Tests] Adds a wait time between setting the index pattern and the time field on TSVB (elastic#74736)
  [Lens] Add styling options for x and y axes on the settings popover (elastic#71829)
  [Maps] add initial location option that fits to data bounds (elastic#74583)
  theme function (elastic#73451)
  [data.ui.query] Write filters to query log from default editor. (elastic#74474)
  [data.search.SearchSource] Move some SearchSource dependencies to the server. (elastic#74607)
  [Canvas][tech-debt] Convert renderers (elastic#74134)
  [security solutions][lists] Adds end to end tests (elastic#74473)
  pluralized for occurrences vs occurrence (elastic#74564)
  Update links that pointed to CONTRIBUTING.md (elastic#74757)
  [Ingest pipelines] Implement tabs in processor flyout (elastic#74469)
  [Event log] Use Alerts client & Actions client when fetching these types of SOs (elastic#73257)
  Bump chalk to 4.1.0 (elastic#73397)
  Index pattern field list - transition away from extending array - introduce and use getAll() (elastic#74718)
  [SECURITY] Bugs css/inspect (elastic#74711)
  [telemetry] update README to downplay ui_metrics (elastic#74635)
  Fixed grammar (elastic#74725)
  [Telemetry][API Integration] size_in_bytes to be a number (elastic#74664)
  [ILM] Convert node details flyout to TS (elastic#73707)
  [Ingest Node Pipelines] Sentence-case processor names (elastic#74645)
  ...
@tylersmalley
Copy link
Contributor

tylersmalley commented Aug 11, 2020 •
edited
Loading

Thanks for the fix, we actually just hit this on the 7.9 branch. Would you mind backporting there as well? https://kibana-ci.elastic.co/job/elastic+kibana+7.9/226/execution/node/337/log/

stratoula added a commit that referenced this pull request Aug 12, 2020
@stratoula
[Functional Tests] Adds a wait time between setting the index pattern…
cd67d6f 
… and the time field on TSVB (#74736) (#74783)

* Adds a wait time between setting the index pattern and the time field on tsvb

* Char by char to set indexpattern to give more time to load the time field

* Add more time

* uncomment commented lines
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 12, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ingest-pipeli…
bbbe9d2 
…nes/processor-forms-a-d

* 'master' of github.com:elastic/kibana: (25 commits)
  [ML] Removing full lodash library imports (elastic#74742)
  [Search] Server strategy example (elastic#71679)
  [Reporting] Fix and test for Listing of Reports (elastic#74453)
  [maps] fix drawing shapes (elastic#74689)
  [Resolver] Improve simulator. Add more click-through tests and panel tests. (elastic#74601)
  Deprecate schema-less specs in Vega (elastic#73805)
  [Security Solution] Rename Administration > Hosts subtab to Endpoints (elastic#74287)
  Timelion deprecation doc (elastic#74508)
  [Functional Tests] Adds a wait time between setting the index pattern and the time field on TSVB (elastic#74736)
  [Lens] Add styling options for x and y axes on the settings popover (elastic#71829)
  [Maps] add initial location option that fits to data bounds (elastic#74583)
  theme function (elastic#73451)
  [data.ui.query] Write filters to query log from default editor. (elastic#74474)
  [data.search.SearchSource] Move some SearchSource dependencies to the server. (elastic#74607)
  [Canvas][tech-debt] Convert renderers (elastic#74134)
  [security solutions][lists] Adds end to end tests (elastic#74473)
  pluralized for occurrences vs occurrence (elastic#74564)
  Update links that pointed to CONTRIBUTING.md (elastic#74757)
  [Ingest pipelines] Implement tabs in processor flyout (elastic#74469)
  [Event log] Use Alerts client & Actions client when fetching these types of SOs (elastic#73257)
  ...

# Conflicts:
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/field_components/text_editor.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/manage_processor_form.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/append.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/bytes.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/circle.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/common_fields/field_name_field.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/common_fields/ignore_missing_field.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/convert.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/csv.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/date.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/date_index_name.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/dissect.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/dot_expander.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/drop.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/index.ts
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/shared.ts
@spalger spalger added the v7.9.3 label Sep 21, 2020
@spalger spalger mentioned this pull request Sep 21, 2020
Merged
spalger pushed a commit that referenced this pull request Sep 22, 2020
@stratoula
[7.9] [Functional Tests] Adds a wait time between setting the index p…
d5e331b 
…attern and the time field on TSVB (#74736) (#78098)

* Adds a wait time between setting the index pattern and the time field on tsvb

* Char by char to set indexpattern to give more time to load the time field

* Add more time

* uncomment commented lines

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlemeshko dmlemeshko dmlemeshko approved these changes

Assignees
No one assigned
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes v7.9.3 v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
6 participants
@stratoula @kibanamachine @elasticmachine @tylersmalley @dmlemeshko @spalger