Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph control tests more #74884

Closed
wants to merge 7 commits into from

Conversation

oatkiller
Copy link
Contributor

Summary

Based on: #74680

  • adds a new matcher `toYieldObjectEqual
  • changes language for the specs a bit
  • resolves wrapper before use

Notes

This type of test should be more robust. Let's discuss a way to make it easier to write them this way.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@oatkiller oatkiller requested a review from michaelolo24 August 12, 2020 17:31
@@ -17,6 +17,7 @@ declare global {
namespace jest {
interface Matchers<R, T> {
toYieldEqualTo(expectedYield: T extends AsyncIterable<infer E> ? E : never): Promise<R>;
toYieldObjectEqualTo(expectedYield: unknown): Promise<R>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❔ Not sure about making this even more complicated. What does it do that toYieldEqualTo doesn't? Would be helpful to read in a comment here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB +235.0B 7.3MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@oatkiller oatkiller closed this Aug 13, 2020
@oatkiller oatkiller deleted the graph-control-tests-more branch March 31, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants