-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard First] Lens Originating App Breadcrumb #75470
[Dashboard First] Lens Originating App Breadcrumb #75470
Conversation
…ibana into feature/lensOriginatingAppBreadcrumb
Pinging @elastic/kibana-app (Team:KibanaApp) |
…riginatingAppBreadcrumb
@elasticmachine merge upstream |
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works as expected, LGTM. That's a nice feature, thanks for adding it. I wonder whether we can even replace the Visualize
breadcrumb with the current app instead of prepending.
Leaving that up to you though, I'm fine with both ways.
core.application.navigateToApp(originatingApp); | ||
}, | ||
text: getAppNameFromId(originatingApp), | ||
} as EuiBreadcrumb, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: This type cast doesn't seem necessary:
{
onClick: () => {
core.application.navigateToApp(originatingApp);
},
text: getAppNameFromId(originatingApp),
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix this in the lens by value PR
That's a really good point, Joe. It could reinforce the 'dashboard first' project by not even providing a link to Visualize. I am considering changing it to:
in the Lens by Value PR |
Changed lens breadcrumbs to reflect the Originating App
* master: (71 commits) [Lens] Show 'No data for this field' for empty field in accordion (elastic#73772) Skip failing lens test Configure ScopedHistory consistenty regardless of URL used to mount app (elastic#75074) Fix returned payload by "search" usage collector (elastic#75340) [Security Solution] Fix missing key error (elastic#75576) Upgrade EUI to v27.4.1 (elastic#75240) Update datasets UI copy to data streams (elastic#75618) [Lens] Register saved object references (elastic#74523) [DOCS] Update links to Beats documentation (elastic#70380) [Enterprise Search] Convert our `public_url` route to `config_data` and collect initialAppData (elastic#75616) [Usage Collection Schemas] Remove Legacy entries (elastic#75652) [Dashboard First] Lens Originating App Breadcrumb (elastic#75470) Improve login UI error message. (elastic#75642) [Security Solution] modify circular deps checker to output images of circular deps graphs (elastic#75579) [Data Telemetry] Add index pattern to identify "meow" attacks (elastic#75163) Migrate CSP usage collector to `kibana_usage_collection` plugin (elastic#75536) [Console] Get ES Config from core (elastic#75406) [Uptime] Add delay in telemetry test (elastic#75162) [Lens] Use index pattern service instead saved object client (elastic#74654) Embeddable input (elastic#73033) ...
Summary
This PR uses the app title fetch method from #75457 to create a clickable breadcrumb in lens that will return the user to the originating app. This will work for every container!
Canvas
Dashboard
How to test this:
The new breadcrumb should show up any time you have created or edited a lens visualization from a container.
Checklist
Delete any items that are not applicable to this PR.
For maintainers