Migrate CSP usage collector to kibana_usage_collection plugin
#75536
Conversation
pgayvallet
added
Feature:Legacy Removal
| const collectorOptions = createCspCollector(http); | ||
| const collector = usageCollection.makeUsageCollector<Usage>(collectorOptions); | ||
| usageCollection.registerCollector(collector); |
There was a problem hiding this comment.
The scripts/telemetry_check.js was kinda picky on the syntax I had to use here: I was not allowed to directly call usageCollection.makeUsageCollector(createCspCollector(http)) and I was forced to manually specify the <Usage> type that is already implicitly defined when calling makeUsageCollector
There was a problem hiding this comment.
Yeah... we are working on improving it to be more developer-friendly. Thank you for sharing your frustration about this 🙂
cc/ @Bamieh
| const kibanaPlugin = body.status.statuses.find((s) => { | ||
| return s.id.indexOf('plugin:kibana') === 0; | ||
| }); | ||
| expect(kibanaPlugin.state).to.be('green'); |
There was a problem hiding this comment.
Removing the init function from the legacy kibana plugin removed the plugin entry from the status, so I had to adapt two tests relying on that. As we are very close to remove the plugin totally, I felt like it was better to remove that than to preserve an empty init function.
It's also likely we'll adapt and enhance these tests once we finish the status API migration anyway.
|
Pinging @elastic/kibana-platform (Team:Platform) |
There was a problem hiding this comment.
Would you mind adding csp to the README in https://github.com/elastic/kibana/blob/master/src/plugins/kibana_usage_collection/README.md please?
Otherwise LGMT
…-csp-usage-collector
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
…tic#75536) * move csp usage collector from legacy kibana plugin to kibana_usage_collection * make scripts/telemetry_check happy. * remove assertion on legacy kibana plugin * remove test on legacy kibana plugin * update README
…) (#75643) * move csp usage collector from legacy kibana plugin to kibana_usage_collection * make scripts/telemetry_check happy. * remove assertion on legacy kibana plugin * remove test on legacy kibana plugin * update README
* master: (71 commits) [Lens] Show 'No data for this field' for empty field in accordion (elastic#73772) Skip failing lens test Configure ScopedHistory consistenty regardless of URL used to mount app (elastic#75074) Fix returned payload by "search" usage collector (elastic#75340) [Security Solution] Fix missing key error (elastic#75576) Upgrade EUI to v27.4.1 (elastic#75240) Update datasets UI copy to data streams (elastic#75618) [Lens] Register saved object references (elastic#74523) [DOCS] Update links to Beats documentation (elastic#70380) [Enterprise Search] Convert our `public_url` route to `config_data` and collect initialAppData (elastic#75616) [Usage Collection Schemas] Remove Legacy entries (elastic#75652) [Dashboard First] Lens Originating App Breadcrumb (elastic#75470) Improve login UI error message. (elastic#75642) [Security Solution] modify circular deps checker to output images of circular deps graphs (elastic#75579) [Data Telemetry] Add index pattern to identify "meow" attacks (elastic#75163) Migrate CSP usage collector to `kibana_usage_collection` plugin (elastic#75536) [Console] Get ES Config from core (elastic#75406) [Uptime] Add delay in telemetry test (elastic#75162) [Lens] Use index pattern service instead saved object client (elastic#74654) Embeddable input (elastic#73033) ...
…tic#75536) * move csp usage collector from legacy kibana plugin to kibana_usage_collection * make scripts/telemetry_check happy. * remove assertion on legacy kibana plugin * remove test on legacy kibana plugin * update README
Summary
Fix #50511
move the
cspusage collector from legacy to thekibana_usage_collectionpluginChecklist