From 49cf7a2f71d29b07408ce47b5da610df7231737b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=B8ren=20Louv-Jansen?= <sorenlouv@gmail.com>
Date: Mon, 26 Oct 2020 13:22:41 +0100
Subject: [PATCH] [APM] Unskip test (#81574)

---
 .../tests/correlations/slow_durations.ts      | 97 +++++++------------
 1 file changed, 37 insertions(+), 60 deletions(-)

diff --git a/x-pack/test/apm_api_integration/basic/tests/correlations/slow_durations.ts b/x-pack/test/apm_api_integration/basic/tests/correlations/slow_durations.ts
index ada67bbec070b..085a81c5f1bf4 100644
--- a/x-pack/test/apm_api_integration/basic/tests/correlations/slow_durations.ts
+++ b/x-pack/test/apm_api_integration/basic/tests/correlations/slow_durations.ts
@@ -25,7 +25,7 @@ export default function ApiTest({ getService }: FtrProviderContext) {
     'user.username,user.id,host.ip,user_agent.name,kubernetes.pod.uuid,url.domain,container.id,service.node.name';
 
   // Failing: See https://github.com/elastic/kibana/issues/81264
-  describe.skip('Slow durations', () => {
+  describe('Slow durations', () => {
     const url = format({
       pathname: `/api/apm/correlations/slow_durations`,
       query: { start, end, durationPercentile, fieldNames },
@@ -40,21 +40,21 @@ export default function ApiTest({ getService }: FtrProviderContext) {
       });
     });
 
-    describe('with default scoring', () => {
-      let response: PromiseReturnType<typeof supertest.get>;
-      before(async () => {
-        await esArchiver.load(archiveName);
-        response = await supertest.get(url);
-      });
-
+    describe('when data is loaded', () => {
+      before(() => esArchiver.load(archiveName));
       after(() => esArchiver.unload(archiveName));
 
-      it('returns successfully', () => {
-        expect(response.status).to.eql(200);
-      });
+      describe('making request with default args', () => {
+        let response: PromiseReturnType<typeof supertest.get>;
+        before(async () => {
+          response = await supertest.get(url);
+
+          it('returns successfully', () => {
+            expect(response.status).to.eql(200);
+          });
 
-      it('returns fields in response', () => {
-        expectSnapshot(Object.keys(response.body.response)).toMatchInline(`
+          it('returns fields in response', () => {
+            expectSnapshot(Object.keys(response.body.response)).toMatchInline(`
           Array [
             "service.node.name",
             "host.ip",
@@ -64,14 +64,14 @@ export default function ApiTest({ getService }: FtrProviderContext) {
             "url.domain",
           ]
         `);
-      });
+          });
 
-      it('returns cardinality for each field', () => {
-        const cardinalitys = Object.values(response.body.response).map(
-          (field: any) => field.cardinality
-        );
+          it('returns cardinality for each field', () => {
+            const cardinalitys = Object.values(response.body.response).map(
+              (field: any) => field.cardinality
+            );
 
-        expectSnapshot(cardinalitys).toMatchInline(`
+            expectSnapshot(cardinalitys).toMatchInline(`
           Array [
             5,
             6,
@@ -81,11 +81,11 @@ export default function ApiTest({ getService }: FtrProviderContext) {
             4,
           ]
         `);
-      });
+          });
 
-      it('returns buckets', () => {
-        const { buckets } = response.body.response['user.id'].value;
-        expectSnapshot(buckets[0]).toMatchInline(`
+          it('returns buckets', () => {
+            const { buckets } = response.body.response['user.id'].value;
+            expectSnapshot(buckets[0]).toMatchInline(`
           Object {
             "bg_count": 32,
             "doc_count": 6,
@@ -93,46 +93,23 @@ export default function ApiTest({ getService }: FtrProviderContext) {
             "score": 0.1875,
           }
         `);
+          });
+        });
       });
-    });
 
-    describe('with different scoring', () => {
-      before(async () => esArchiver.load(archiveName));
-      after(() => esArchiver.unload(archiveName));
-
-      it(`returns buckets for each score`, async () => {
-        const promises = ['percentage', 'jlh', 'chi_square', 'gnd'].map(async (scoring) => {
-          const response = await supertest.get(
-            format({
-              pathname: `/api/apm/correlations/slow_durations`,
-              query: { start, end, durationPercentile, fieldNames, scoring },
-            })
-          );
-
-          return { name: scoring, value: response.body.response['user.id'].value.buckets[0].score };
+      describe('making a request for each "scoring"', () => {
+        ['percentage', 'jlh', 'chi_square', 'gnd'].map(async (scoring) => {
+          it(`returns response for scoring "${scoring}"`, async () => {
+            const response = await supertest.get(
+              format({
+                pathname: `/api/apm/correlations/slow_durations`,
+                query: { start, end, durationPercentile, fieldNames, scoring },
+              })
+            );
+
+            expect(response.status).to.be(200);
+          });
         });
-
-        const res = await Promise.all(promises);
-        expectSnapshot(res).toMatchInline(`
-          Array [
-            Object {
-              "name": "percentage",
-              "value": 0.1875,
-            },
-            Object {
-              "name": "jlh",
-              "value": 3.33506905769659,
-            },
-            Object {
-              "name": "chi_square",
-              "value": 219.192006524483,
-            },
-            Object {
-              "name": "gnd",
-              "value": 0.671406580688819,
-            },
-          ]
-        `);
       });
     });
   });