[DX] Bump TS version to v4.1 #83397

mshustov · 2020-11-16T08:21:39Z

Summary

Release notes: https://devblogs.microsoft.com/typescript/announcing-typescript-4-1/
Breaking changes: https://devblogs.microsoft.com/typescript/announcing-typescript-4-1/#breaking-changes

I muted TS errors with @ts-expect-error in several places. Code owners, fix them in the branch or as the follow-up, please.

src/plugins/discover/public/application/components/sidebar/change_indexpattern.tsx

mshustov · 2020-11-16T08:35:42Z

src/plugins/embeddable/public/lib/containers/container.ts

@@ -181,6 +181,7 @@ export abstract class Container<
        // If we hit this, the panel was removed before the embeddable finished loading.
        if (this.input.panels[id] === undefined) {
          subscription.unsubscribe();
+          // @ts-expect-error undefined in not assignable to TEmbeddable | ErrorEmbeddable


we need either to change untilEmbeddableLoaded signature or fix the code @elastic/kibana-app-arch

Maybe

reject(new Error('The panel was removed before the embeddable finished loading.'));

/cc @stacey-gammon

mshustov · 2020-11-16T08:36:22Z

...eddable/public/lib/test_samples/embeddables/contact_card/contact_card_embeddable_factory.tsx

@@ -56,6 +56,7 @@ export class ContactCardEmbeddableFactory
          <ContactCardInitializer
            onCancel={() => {
              modalSession.close();
+              // @ts-expect-error


undefined is not assignable to Partial<ContactCardEmbeddableInput> @elastic/kibana-app-arch

Maybe

reject(new Error('Cancelled!'));

mshustov · 2020-11-16T08:36:45Z

x-pack/plugins/security_solution/public/timelines/components/duration/index.tsx

@@ -23,6 +23,7 @@ export const Duration = React.memo<{
 }>(({ contextId, eventId, fieldName, value }) => (
  <DefaultDraggable
    id={`duration-default-draggable-${contextId}-${eventId}-${fieldName}-${value}`}
+    // @ts-expect-error


name is not defined in the scope. It uses deprecated global var name from lib.dom.d.ts. See all other changes in security_solution plugin code. @elastic/siem

@restrry thanks so much for catching this.

We are now tracking work to fix this. Thanks!

mshustov · 2020-11-16T08:37:12Z

...store/public/application/sections/home/repository_list/repository_table/repository_table.tsx

-        {...reactRouterNavigate(history, linkToAddRepository(name))}
+        {...reactRouterNavigate(
+          history,
+          // @ts-expect-error


name is not defined in the scope. It uses deprecated global var name from lib.dom.d.ts. @elastic/es-ui

I think you intended this comment to be on line 40 of hdfs_settings.tsx, above, correct?

If so, could you clarify the error that's expected on this line?

I think you intended this comment to be on line 40 of hdfs_settings.tsx, above, correct?

TS doesn't complain there, does it?

If so, could you clarify the error that's expected on this line?

Could you elaborate? As state in the comment: name is not defined in the local scope and references a deprecated property name from the global scope.

I've tested this locally and it looks like that name value can safely be removed. Would you mind removing the TS comment and the reference to the global "name" @restrry ? Otherwise I can do it as a follow up chore. Either way, no need to block on this.

I would prefer the owners to remove this code, as some nuances may pop up.

mshustov · 2020-11-16T08:38:04Z

@elastic/kibana-telemetry telemetry tests are failing again

afharo · 2020-11-16T16:04:32Z

@restrry, updating the snapshot should fix it, but I've created #83440 to permanently fix it for this one and any future updates.

azasypkin

LGTM

This reverts commit 3de48db.

mshustov · 2020-11-20T10:38:08Z

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.searchbar.md

@@ -7,7 +7,7 @@
 <b>Signature:</b>

 ```typescript
-SearchBar: React.ComponentClass<Pick<Pick<SearchBarProps, "query" | "isLoading" | "filters" | "onRefresh" | "onRefreshChange" | "refreshInterval" | "intl" | "indexPatterns" | "dataTestSubj" | "screenTitle" | "showQueryInput" | "showDatePicker" | "showAutoRefreshOnly" | "dateRangeFrom" | "dateRangeTo" | "isRefreshPaused" | "customSubmitButton" | "timeHistory" | "indicateNoData" | "onFiltersUpdated" | "trackUiMetric" | "savedQuery" | "showSaveQuery" | "onClearSavedQuery" | "showQueryBar" | "showFilterBar" | "onQueryChange" | "onQuerySubmit" | "onSaved" | "onSavedQueryUpdated">, "query" | "isLoading" | "filters" | "onRefresh" | "onRefreshChange" | "refreshInterval" | "indexPatterns" | "dataTestSubj" | "screenTitle" | "showQueryInput" | "showDatePicker" | "showAutoRefreshOnly" | "dateRangeFrom" | "dateRangeTo" | "isRefreshPaused" | "customSubmitButton" | "timeHistory" | "indicateNoData" | "onFiltersUpdated" | "trackUiMetric" | "savedQuery" | "showSaveQuery" | "onClearSavedQuery" | "showQueryBar" | "showFilterBar" | "onQueryChange" | "onQuerySubmit" | "onSaved" | "onSavedQueryUpdated">, any> & {
-    WrappedComponent: React.ComponentType<Pick<SearchBarProps, "query" | "isLoading" | "filters" | "onRefresh" | "onRefreshChange" | "refreshInterval" | "intl" | "indexPatterns" | "dataTestSubj" | "screenTitle" | "showQueryInput" | "showDatePicker" | "showAutoRefreshOnly" | "dateRangeFrom" | "dateRangeTo" | "isRefreshPaused" | "customSubmitButton" | "timeHistory" | "indicateNoData" | "onFiltersUpdated" | "trackUiMetric" | "savedQuery" | "showSaveQuery" | "onClearSavedQuery" | "showQueryBar" | "showFilterBar" | "onQueryChange" | "onQuerySubmit" | "onSaved" | "onSavedQueryUpdated"> & ReactIntl.InjectedIntlProps>;
+SearchBar: React.ComponentClass<Pick<Pick<SearchBarProps, "query" | "isLoading" | "filters" | "intl" | "indexPatterns" | "dataTestSubj" | "refreshInterval" | "screenTitle" | "onRefresh" | "onRefreshChange" | "showQueryInput" | "showDatePicker" | "showAutoRefreshOnly" | "dateRangeFrom" | "dateRangeTo" | "isRefreshPaused" | "customSubmitButton" | "timeHistory" | "indicateNoData" | "onFiltersUpdated" | "trackUiMetric" | "savedQuery" | "showSaveQuery" | "onClearSavedQuery" | "showQueryBar" | "showFilterBar" | "onQueryChange" | "onQuerySubmit" | "onSaved" | "onSavedQueryUpdated">, "query" | "isLoading" | "filters" | "indexPatterns" | "dataTestSubj" | "refreshInterval" | "screenTitle" | "onRefresh" | "onRefreshChange" | "showQueryInput" | "showDatePicker" | "showAutoRefreshOnly" | "dateRangeFrom" | "dateRangeTo" | "isRefreshPaused" | "customSubmitButton" | "timeHistory" | "indicateNoData" | "onFiltersUpdated" | "trackUiMetric" | "savedQuery" | "showSaveQuery" | "onClearSavedQuery" | "showQueryBar" | "showFilterBar" | "onQueryChange" | "onQuerySubmit" | "onSaved" | "onSavedQueryUpdated">, any> & {


@elastic/kibana-app-services would it possible to fix the problem #77678 (comment), please ?

mikecote

Alerting team code changes LGTM

flash1293

KibanaApp changes LGTM, code review only

spalger

Operations: LGTM

jfsiii

Fleet changes LGTM

weltenwort

infra changes LGTM

dmlemeshko

Kibana QA changes LGTM

clintandrewhall

LGTM!

cee-chen

Enterprise Search file changes look fine!

kibanamachine · 2020-11-24T14:05:23Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b6a8e15

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`advancedSettings`	919.6KB	919.6KB	-11.0B
`beatsManagement`	581.0KB	581.0KB	+92.0B
`console`	982.1KB	982.2KB	+99.0B
`lens`	936.9KB	936.9KB	+20.0B
`ml`	5.2MB	5.2MB	+99.0B
`searchprofiler`	690.7KB	690.8KB	+99.0B
`security`	787.1KB	787.1KB	+7.0B
`securitySolution`	7.9MB	7.9MB	+9.0B
`snapshotRestore`	583.4KB	583.5KB	+21.0B
`transform`	1021.2KB	1021.3KB	+99.0B
`triggersActionsUi`	1.5MB	1.5MB	+99.0B
`watcher`	955.2KB	955.3KB	+99.0B
total			+732.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`embeddable`	221.5KB	221.6KB	+9.0B

History

💚 Build #89623 succeeded 4c212f6
💔 Build #89589 failed 46e689f
💚 Build #89182 succeeded 138b222
💔 Build #89177 failed 3de48db
💔 Build #88275 failed 423374f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jloleysens

Changes look good to me! Let me know what you decide RE the global name value @restrry

jloleysens · 2020-11-24T14:22:24Z

...store/public/application/sections/home/repository_list/repository_table/repository_table.tsx

-        {...reactRouterNavigate(history, linkToAddRepository(name))}
+        {...reactRouterNavigate(
+          history,
+          // @ts-expect-error


I've tested this locally and it looks like that name value can safely be removed. Would you mind removing the TS comment and the reference to the global "name" @restrry ? Otherwise I can do it as a follow up chore. Either way, no need to block on this.

oatkiller

Thank you!

* bump version to 4.1.1-rc * fix code to run kbn bootstrap * fix errors * DO NOT MERGE. mute errors and ping teams to fix them * Address EuiSelectableProps configuration in discover sidebar * use explicit type for EuiSelectable * update to ts v4.1.2 * fix ts error in EuiSelectable * update docs * update prettier with ts version support * Revert "update prettier with ts version support" This reverts commit 3de48db. * address another new problem Co-authored-by: Chandler Prall <chandler.prall@gmail.com> # Conflicts: # test/functional/services/remote/remote.ts

* master: (41 commits) [Maps] fix code-owners (elastic#84265) [@kbn/utils] Clean target before build (elastic#84253) [code coverage] collect for oss integration tests (elastic#83907) [APM] Use `asTransactionRate` consistently everywhere (elastic#84213) Attempt to fix incremental build error (elastic#84152) Unskip "Copy dashboards to space" (elastic#84115) Remove expressions.legacy from README (elastic#79681) Expression: Add render mode and use it for canvas interactivity (elastic#83559) [deb/rpm] Move systemd service to /usr/lib/systemd/system (elastic#83571) [Security Solution][Resolver] Allow a configurable entity_id field (elastic#81679) [ML] Space permision checks for job deletion (elastic#83871) [build] Provide ARM build of RE2 (elastic#84163) TSVB should use "histogram:maxBars" and "histogram:barTarget" settings for auto instead of a default 100 buckets (elastic#83628) [Workplace Search] Initial rendering of Org Sources (elastic#84164) update geckodriver to 0.28 (elastic#84085) Fix timelion vis escapes single quotes (elastic#84196) [Security Solution] Fix incorrect time for dns histogram (elastic#83532) [DX] Bump TS version to v4.1 (elastic#83397) [Security Solution] Add endpoint policy revision number (elastic#83982) [Fleet] Integration Policies List view (elastic#83634) ...

mshustov added 4 commits November 13, 2020 16:16

bump version to 4.1.1-rc

70eade7

fix code to run kbn bootstrap

41b63e8

fix errors

c64df93

DO NOT MERGE. mute errors and ping teams to fix them

81d4dcd

mshustov commented Nov 16, 2020

View reviewed changes

src/plugins/discover/public/application/components/sidebar/change_indexpattern.tsx Outdated Show resolved Hide resolved

mshustov commented Nov 16, 2020

View reviewed changes

afharo mentioned this pull request Nov 16, 2020

Remove dependency of tests on strict SyntaxKind values #83440

Merged

2 tasks

Address EuiSelectableProps configuration in discover sidebar

e25f7d5

mshustov mentioned this pull request Nov 17, 2020

Update typescript eslint to v4.8 #83520

Merged

mshustov added 7 commits November 17, 2020 14:33

Merge remote-tracking branch 'origin/ts-4-1-1' into ts-4-1-1

6bc2224

use explicit type for EuiSelectable

fad9a16

Merge branch 'master' into ts-4-1-1

423374f

Merge branch 'master' into ts-4-1-1

3987a37

update to ts v4.1.2

8beade8

fix ts error in EuiSelectable

1d23852

update docs

594ced8

mshustov added chore Feature:Dependencies release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0 labels Nov 20, 2020

mshustov marked this pull request as ready for review November 20, 2020 08:58

mshustov requested a review from a team as a code owner November 20, 2020 08:58

mshustov requested a review from a team November 20, 2020 08:58

mshustov requested a review from a team as a code owner November 20, 2020 08:58

azasypkin approved these changes Nov 20, 2020

View reviewed changes

update prettier with ts version support

3de48db

mshustov changed the title ~~[WIP] Bump TS version to v4.1~~ [DX] Bump TS version to v4.1 Nov 20, 2020

Revert "update prettier with ts version support"

138b222

This reverts commit 3de48db.

pgayvallet approved these changes Nov 20, 2020

View reviewed changes

mshustov commented Nov 20, 2020

View reviewed changes

mikecote approved these changes Nov 20, 2020

View reviewed changes

flash1293 approved these changes Nov 20, 2020

View reviewed changes

spalger approved these changes Nov 20, 2020

View reviewed changes

jfsiii approved these changes Nov 23, 2020

View reviewed changes

mshustov added 2 commits November 23, 2020 13:59

Merge branch 'master' into ts-4-1-1

46e689f

address another new problem

4c212f6

weltenwort approved these changes Nov 23, 2020

View reviewed changes

dmlemeshko approved these changes Nov 23, 2020

View reviewed changes

streamich approved these changes Nov 23, 2020

View reviewed changes

clintandrewhall approved these changes Nov 23, 2020

View reviewed changes

cee-chen approved these changes Nov 23, 2020

View reviewed changes

mshustov requested a review from cjcenizal November 24, 2020 07:58

Merge branch 'master' into ts-4-1-1

b6a8e15

jloleysens approved these changes Nov 24, 2020

View reviewed changes

oatkiller approved these changes Nov 24, 2020

View reviewed changes

mshustov merged commit 5ec6fe3 into elastic:master Nov 24, 2020

mshustov deleted the ts-4-1-1 branch November 24, 2020 15:04

mshustov mentioned this pull request Nov 24, 2020

[7.x] [DX] Bump TS version to v4.1 (#83397) #84234

Merged

mshustov added the backported label Nov 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DX] Bump TS version to v4.1 #83397

[DX] Bump TS version to v4.1 #83397

mshustov commented Nov 16, 2020 •

edited

Loading

mshustov Nov 16, 2020

streamich Nov 18, 2020

mshustov Nov 16, 2020

streamich Nov 18, 2020

mshustov Nov 16, 2020

oatkiller Nov 23, 2020

oatkiller Nov 23, 2020

mshustov Nov 16, 2020

cjcenizal Nov 20, 2020 •

edited

Loading

cjcenizal Nov 20, 2020

mshustov Nov 24, 2020 •

edited

Loading

jloleysens Nov 24, 2020

mshustov Nov 24, 2020

mshustov commented Nov 16, 2020

afharo commented Nov 16, 2020

azasypkin left a comment

mshustov Nov 20, 2020 •

edited

Loading

mikecote left a comment

flash1293 left a comment

spalger left a comment

jfsiii left a comment

weltenwort left a comment

dmlemeshko left a comment

clintandrewhall left a comment

cee-chen left a comment

kibanamachine commented Nov 24, 2020

jloleysens left a comment

jloleysens Nov 24, 2020

oatkiller left a comment

[DX] Bump TS version to v4.1 #83397

[DX] Bump TS version to v4.1 #83397

Conversation

mshustov commented Nov 16, 2020 • edited Loading

Summary

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cjcenizal Nov 20, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mshustov Nov 24, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mshustov commented Nov 16, 2020

afharo commented Nov 16, 2020

azasypkin left a comment

Choose a reason for hiding this comment

mshustov Nov 20, 2020 • edited Loading

Choose a reason for hiding this comment

mikecote left a comment

Choose a reason for hiding this comment

flash1293 left a comment

Choose a reason for hiding this comment

spalger left a comment

Choose a reason for hiding this comment

jfsiii left a comment

Choose a reason for hiding this comment

weltenwort left a comment

Choose a reason for hiding this comment

dmlemeshko left a comment

Choose a reason for hiding this comment

clintandrewhall left a comment

Choose a reason for hiding this comment

cee-chen left a comment

Choose a reason for hiding this comment

kibanamachine commented Nov 24, 2020

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

jloleysens left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oatkiller left a comment

Choose a reason for hiding this comment

mshustov commented Nov 16, 2020 •

edited

Loading

cjcenizal Nov 20, 2020 •

edited

Loading

mshustov Nov 24, 2020 •

edited

Loading

mshustov Nov 20, 2020 •

edited

Loading