Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Create vis_type_xy plugin to replace histogram, area and line charts (#78154) #86534

Merged
merged 3 commits into from
Dec 19, 2020

Conversation

nickofthyme
Copy link
Contributor

Backports the following commits to 7.x:

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
charts 49 76 +27
visTypeVislib 280 262 -18
visTypeXy 4 97 +93
total +102

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
charts 57.4KB 57.4KB +1.0B
discover 457.5KB 453.6KB -4.0KB
triggersActionsUi 1.5MB 1.5MB -26.9KB
visDefaultEditor 300.5KB 301.0KB +579.0B
visTypeVislib 702.9KB 643.8KB -59.1KB
visTypeXy 0.0B 137.6KB +137.6KB
total +48.3KB

Distributable file count

id before after diff
default 47573 48346 +773
oss 28138 28148 +10

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
charts 147.9KB 178.7KB +30.9KB
discover 81.1KB 81.2KB +78.0B
triggersActionsUi 162.0KB 162.1KB +102.0B
visTypeMetric 26.3KB 26.3KB -10.0B
visTypeVislib 66.8KB 46.6KB -20.2KB
visTypeXy 4.2KB 67.6KB +63.5KB
visualizations 169.2KB 169.3KB +111.0B
total +74.5KB
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 31 32 +1
visTypeVislib 7 5 -2
visTypeXy 0 3 +3
total +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nickofthyme nickofthyme merged commit 8656337 into elastic:7.x Dec 19, 2020
@nickofthyme nickofthyme deleted the backport/7.x/pr-78154 branch December 19, 2020 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants