-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vislib] Use timestamp on brush event instead of iso dates #91483
Conversation
Pinging @elastic/kibana-app (Team:KibanaApp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Could you please also tweak the docs 🙏
I think it makes sense to tweak as part of this:
https://github.com/elastic/kibana/blob/master/docs/user/dashboard/url-drilldown.asciidoc
from and to values of selected range. Depending on your data, could be either a date or number.
---> to probably something like:
from and to values of the selected range as numbers
There is also a functional test that should have caught this "regression", could you please tweak an assertion so we would catch it? Probably we need also to check that time range in discover is not now-15min
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the docs and test changes 🚀
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Code LGTM, tested on Chrome, all works wonderfully with the example drilldown:
|
…1483) * [Vislib] Use timestamp on brush event instead of iso dates * Fix functional test and update documentation * Update documentation Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…1483) * [Vislib] Use timestamp on brush event instead of iso dates * Fix functional test and update documentation * Update documentation Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* master: (157 commits) [DOCS] Adds machine learning to the security section of alerting (elastic#91501) [Uptime] Ping list step screenshot caption formatting (elastic#91403) [Vislib] Use timestamp on brush event instead of iso dates (elastic#91483) [Application Usage] Remove deprecated & unused legacy.appChanged API (elastic#91464) Migrate logstash, monitoring, url_drilldowns, xpack_legacy to ts projects (elastic#91194) [APM] Wrap Elasticsearch client errors (elastic#91125) [APM] Fix optimize-tsconfig script (elastic#91487) [Discover][docs] Add searchFieldsFromSource description (elastic#90980) Adds support for 'ip' data type (elastic#85087) [Detection Rules] Add updates from 7.11.2 rules (elastic#91553) [SECURITY SOLUTION] Eql in timeline (elastic#90816) [APM] Correlations Beta (elastic#86477) (elastic#89952) [Security Solutions][Detection Engine] Adds a warning banner when the alerts data has not been migrated yet. (elastic#90258) [Security Solution] [Timeline] Endpoint row renderers (2nd batch) (elastic#91446) skip flaky suite (elastic#91450) skip flaky suite (elastic#91592) [Security Solution][Endpoint][Admin] Endpoint Details UX Enhancements (elastic#90870) [ML] Add better UI support for runtime fields Transforms (elastic#90363) [Security Solution] [Detections] Replace 'partial failure' with 'warning' for rule statuses (elastic#91167) [Security Solution][Detections] Adds Indicator path config for indicator match rules (elastic#91260) ...
…91623) * [Vislib] Use timestamp on brush event instead of iso dates * Fix functional test and update documentation * Update documentation Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…91622) * [Vislib] Use timestamp on brush event instead of iso dates * Fix functional test and update documentation * Update documentation Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Summary
Closes #90923.
Url drilldowns on brush event for all visualizations emit timestamps instead of the vislib xy axis that emit ISO strings. We want to change this behavior and emit timestamps instead in order to be in line with the rest.
Url drilldowns are in beta and introduced on 7.10 so we are not going to proceed with migrating the existing URL templates.
How to test it
Create a URL drilldown (range) and add the following URL template
{{kibanaUrl}}/app/discover#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:'{{date event.from}}',to:'{{date event.to}}'))&_a=(columns:!(_source),filters:{{rison context.panel.filters}},index:'{{context.panel.indexPatternId}}',interval:auto,query:(language:{{context.panel.query.language}},query:'{{context.panel.query.query}}'),sort:!())
It should work correctly now with the
date
function