Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Track tile loading status #91585

Merged
merged 18 commits into from
Mar 4, 2021
Merged

[Maps] Track tile loading status #91585

merged 18 commits into from
Mar 4, 2021

Conversation

thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented Feb 16, 2021 •
edited
Loading

Summary

Closes #76237

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@thomasneirynck thomasneirynck added WIP Work in progress [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.13.0 v8.0.0 release_note:fix labels Feb 16, 2021
@thomasneirynck thomasneirynck mentioned this pull request Feb 16, 2021
Closed
@thomasneirynck thomasneirynck marked this pull request as ready for review February 18, 2021 14:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

nreese
nreese reviewed Feb 25, 2021
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having the loading indicator spinning for vector tile layers is a great improvement and really makes the vector tile layers feel alive.

x-pack/plugins/maps/public/connected_components/mb_map/mb_map.tsx Outdated Show resolved Hide resolved
x-pack/plugins/maps/public/connected_components/mb_map/tile_status_tracker.ts Outdated Show resolved Hide resolved
x-pack/plugins/maps/public/connected_components/mb_map/tile_status_tracker.ts Outdated Show resolved Hide resolved
x-pack/plugins/maps/public/connected_components/mb_map/tile_status_tracker.ts Outdated Show resolved Hide resolved
x-pack/plugins/maps/public/connected_components/mb_map/tile_status_tracker.ts Outdated Show resolved Hide resolved
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
maps 757 758 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.7MB 2.7MB +3.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomasneirynck thomasneirynck requested review from nreese and kindsun March 4, 2021 16:05
nreese
nreese approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
code review, tested in chrome

@thomasneirynck thomasneirynck merged commit db3db0c into elastic:master Mar 4, 2021
@thomasneirynck thomasneirynck mentioned this pull request Mar 4, 2021
Merged
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Mar 4, 2021
@thomasneirynck
[Maps] Track tile loading status (elastic#91585)
b926e41
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 4, 2021
@gmmorris
Merge branch 'master' into actions/terminology-api
55ff443 
* master: (107 commits)
  [Logs UI] Fix log stream data fetching (elastic#93201)
  [App Search] Added relevance tuning search preview (elastic#93054)
  [Canvas] Fix reports embeddables (elastic#93482)
  [ILM] Added new functional test in ILM for creating a new policy (elastic#92936)
  Remove direct dependency on statehood package (elastic#93592)
  [Maps] Track tile loading status (elastic#91585)
  [Discover][Doc] Improve main documentation (elastic#91854)
  [Upgrade Assistant] Disable UA and add prompt (elastic#92834)
  [Snapshot Restore] Remove cloud validation for slm policy (elastic#93609)
  [Maps] Support GeometryCollections in GeoJson upload (elastic#93507)
  [XY Charts] fix partial histogram endzones annotations (elastic#93091)
  [Core] Simplify context typings (elastic#93579)
  [Alerting] Improving health status check (elastic#93282)
  [Discover] Restore context documentation (elastic#90784)
  [core-docs] Edits core-intro section for the new docs system (elastic#93540)
  add missed codeowners (elastic#89714)
  fetch node labels via script execution (elastic#93225)
  [Security Solution] Adds getMockTheme function (elastic#92840)
  Sort dependencies in package.json correctly (elastic#93590)
  [Bug] missing timepicker:quickRanges migration (elastic#93409)
  ...
thomasneirynck added a commit that referenced this pull request Mar 4, 2021
@thomasneirynck
[Maps] Track tile loading status (#91585) (#93659)
af60da2
@nreese nreese mentioned this pull request Mar 10, 2021
Merged
@thomasneirynck thomasneirynck mentioned this pull request Mar 17, 2021
Merged
@nreese nreese mentioned this pull request Apr 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

@kindsun kindsun Awaiting requested review from kindsun

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:fix v7.13.0 v8.0.0 WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maps] Feature Request: have maps tile layers show loading status
5 participants
@thomasneirynck @elasticmachine @kibanamachine @nreese @kindsun