From e272937be190d0711f03c767ef706274106dafc0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20Ferna=CC=81ndez=20Haro?= Date: Fri, 19 Feb 2021 16:32:57 +0100 Subject: [PATCH 1/3] Unskip ui_settings integration tests --- src/core/server/ui_settings/integration_tests/routes.test.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/core/server/ui_settings/integration_tests/routes.test.ts b/src/core/server/ui_settings/integration_tests/routes.test.ts index 9c38b9e21f2c4..89b08f35ca364 100644 --- a/src/core/server/ui_settings/integration_tests/routes.test.ts +++ b/src/core/server/ui_settings/integration_tests/routes.test.ts @@ -9,8 +9,7 @@ import { schema } from '@kbn/config-schema'; import * as kbnTestServer from '../../../test_helpers/kbn_server'; -// FLAKY: https://github.com/elastic/kibana/issues/89191 -describe.skip('ui settings service', () => { +describe('ui settings service', () => { describe('routes', () => { let root: ReturnType; beforeAll(async () => { From 6943df33ef698fef21d01876578de998344cd851 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20Ferna=CC=81ndez=20Haro?= Date: Mon, 22 Feb 2021 10:54:33 +0100 Subject: [PATCH 2/3] Run 200 times the test to ensure it does not fail --- src/core/server/ui_settings/integration_tests/routes.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/server/ui_settings/integration_tests/routes.test.ts b/src/core/server/ui_settings/integration_tests/routes.test.ts index 89b08f35ca364..c421abff97ec2 100644 --- a/src/core/server/ui_settings/integration_tests/routes.test.ts +++ b/src/core/server/ui_settings/integration_tests/routes.test.ts @@ -9,7 +9,7 @@ import { schema } from '@kbn/config-schema'; import * as kbnTestServer from '../../../test_helpers/kbn_server'; -describe('ui settings service', () => { +describe.each(Array.from(new Array(200), (_, index) => index))('ui settings service #%d', () => { describe('routes', () => { let root: ReturnType; beforeAll(async () => { From 4975f4ad0509c59554a59bf4d999fa67bfb9d564 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20Ferna=CC=81ndez=20Haro?= Date: Mon, 22 Feb 2021 12:53:37 +0100 Subject: [PATCH 3/3] Revert 200 execution loop --- src/core/server/ui_settings/integration_tests/routes.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/server/ui_settings/integration_tests/routes.test.ts b/src/core/server/ui_settings/integration_tests/routes.test.ts index c421abff97ec2..89b08f35ca364 100644 --- a/src/core/server/ui_settings/integration_tests/routes.test.ts +++ b/src/core/server/ui_settings/integration_tests/routes.test.ts @@ -9,7 +9,7 @@ import { schema } from '@kbn/config-schema'; import * as kbnTestServer from '../../../test_helpers/kbn_server'; -describe.each(Array.from(new Array(200), (_, index) => index))('ui settings service #%d', () => { +describe('ui settings service', () => { describe('routes', () => { let root: ReturnType; beforeAll(async () => {