Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Support GeometryCollections in GeoJson upload #93507

Merged
merged 1 commit into from
Mar 4, 2021
Merged

[Maps] Support GeometryCollections in GeoJson upload #93507

merged 1 commit into from
Mar 4, 2021

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Mar 3, 2021

Fixes #93254

Update geo json upload to support files with GeometryCollection features.

Test file

{
  "type": "FeatureCollection",
  "features": [
    {
      "type": "Feature",
      "properties": {
        "population": 200
      },
      "geometry": {
        "type": "GeometryCollection",
        "geometries": [
          {
            "type": "Point",
            "coordinates": [100.0, 0.0]
          },
          {
            "type": "LineString",
            "coordinates": [ [101.0, 0.0], [102.0, 1.0] ]
          }
        ]
      }
    }
  ]
}

@nreese nreese added release_note:fix [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.13.0 labels Mar 3, 2021
@nreese nreese requested a review from thomasneirynck March 3, 2021 20:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

nreese
nreese commented Mar 3, 2021
View reviewed changes
x-pack/plugins/file_upload/public/importer/geojson_importer/geojson_importer.ts
const coordinates =
geoFieldType === ES_FIELD_TYPES.GEO_SHAPE
? {
type: geometry.type.toLowerCase(),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

geometry types does not need to be lower cased for indexing into Elasticsearch.

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / general / X-Pack Spaces API Integration Tests -- security_and_spaces.x-pack/test/spaces_api_integration/security_and_spaces/apis/delete·ts.spaces api with security delete superuser from the space_1 space should return 204 when referencing the space_1 space explicitly in the URL

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/92358

[00:00:00]       │
[00:00:00]         └-: spaces api with security
[00:00:00]           │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] moving index [.ds-ilm-history-5-2021.03.03-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] in policy [ilm-history-ilm-policy]
[00:00:00]           └-> "before all" hook in "spaces api with security"
[00:00:00]           └-> "before all" hook in "spaces api with security"
[00:00:00]             │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] moving index [.ds-ilm-history-5-2021.03.03-000001] from [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] to [{"phase":"hot","action":"rollover","name":"check-rollover-ready"}] in policy [ilm-history-ilm-policy]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added role [kibana_legacy_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added role [kibana_dual_privileges_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added role [kibana_dual_privileges_dashboard_only_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added role [kibana_rbac_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added role [kibana_rbac_dashboard_only_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added role [kibana_rbac_default_space_all_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added role [kibana_rbac_default_space_read_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added role [kibana_rbac_space_1_all_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added role [kibana_rbac_space_1_read_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added role [kibana_rbac_space_2_all_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added role [kibana_rbac_space_2_read_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added role [kibana_rbac_space_1_2_all_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added role [kibana_rbac_space_1_2_read_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added role [kibana_rbac_default_space_saved_objects_all_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added role [kibana_rbac_default_space_saved_objects_read_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added role [kibana_rbac_space_1_saved_objects_all_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added role [kibana_rbac_space_1_saved_objects_read_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added user [not_a_kibana_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added user [a_kibana_legacy_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added user [a_kibana_dual_privileges_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added user [a_kibana_dual_privileges_dashboard_only_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added user [a_kibana_rbac_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added user [a_kibana_rbac_dashboard_only_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added user [a_kibana_rbac_default_space_all_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added user [a_kibana_rbac_default_space_read_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added user [a_kibana_rbac_space_1_all_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added user [a_kibana_rbac_space_1_read_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added user [a_kibana_rbac_space_2_all_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added user [a_kibana_rbac_space_2_read_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added user [a_kibana_rbac_space_1_2_all_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added user [a_kibana_rbac_space_1_2_read_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added user [a_kibana_rbac_default_space_saved_objects_all_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added user [a_kibana_rbac_default_space_saved_objects_read_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added user [a_kibana_rbac_space_1_saved_objects_all_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added user [a_kibana_rbac_space_1_saved_objects_read_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added user [a_apm_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added user [a_machine_learning_admin]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added user [a_machine_learning_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] added user [a_monitoring_user]
[00:03:54]           └-: delete
[00:03:54]             └-> "before all" hook in "delete"
[00:04:56]             └-: superuser from the space_1 space
[00:04:56]               └-> "before all" hook for "should return 204 when referencing the space_1 space explicitly in the URL"
[00:04:56]               └-> should return 204 when referencing the space_1 space explicitly in the URL
[00:04:56]                 └-> "before each" hook: global before each for "should return 204 when referencing the space_1 space explicitly in the URL"
[00:04:56]                 └-> "before each" hook for "should return 204 when referencing the space_1 space explicitly in the URL"
[00:04:56]                   │ info [saved_objects/spaces] Loading "mappings.json"
[00:04:56]                   │ info [saved_objects/spaces] Loading "data.json"
[00:04:56]                   │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] [.kibana_task_manager_8.0.0_001/59cqVuSORhycsQX3zmhSxg] deleting index
[00:04:56]                   │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] [.kibana_8.0.0_001/YDmG70paTEmdysmUjWwzfQ] deleting index
[00:04:56]                   │ info [saved_objects/spaces] Deleted existing index ".kibana_8.0.0_001"
[00:04:56]                   │ info [saved_objects/spaces] Deleted existing index ".kibana_task_manager_8.0.0_001"
[00:04:56]                   │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] [.kibana_8.0.0_001] creating index, cause [api], templates [], shards [1]/[0]
[00:04:56]                   │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_8.0.0_001][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_8.0.0_001][0]]"
[00:04:56]                   │ info [saved_objects/spaces] Created index ".kibana_8.0.0_001"
[00:04:56]                   │ debg [saved_objects/spaces] ".kibana_8.0.0_001" settings {"index":{"auto_expand_replicas":"0-1","number_of_replicas":"0","number_of_shards":"1"}}
[00:04:56]                   │ info [saved_objects/spaces] Indexed 31 docs into ".kibana"
[00:04:56]                   │ debg Migrating saved objects
[00:04:56]                   │ proc [kibana]   log   [21:16:27.556] [warning][collector-set][plugins][usageCollection] ResponseError: index_not_found_exception
[00:04:56]                   │ proc [kibana]     at onBody (/dev/shm/workspace/kibana-build-xpack-12/node_modules/@elastic/elasticsearch/lib/Transport.js:333:23)
[00:04:56]                   │ proc [kibana]     at IncomingMessage.onEnd (/dev/shm/workspace/kibana-build-xpack-12/node_modules/@elastic/elasticsearch/lib/Transport.js:260:11)
[00:04:56]                   │ proc [kibana]     at IncomingMessage.emit (events.js:327:22)
[00:04:56]                   │ proc [kibana]     at endReadableNT (internal/streams/readable.js:1327:12)
[00:04:56]                   │ proc [kibana]     at processTicksAndRejections (internal/process/task_queues.js:80:21) {
[00:04:56]                   │ proc [kibana]   meta: {
[00:04:56]                   │ proc [kibana]     body: { error: [Object], status: 404 },
[00:04:56]                   │ proc [kibana]     statusCode: 404,
[00:04:56]                   │ proc [kibana]     headers: {
[00:04:56]                   │ proc [kibana]       'content-type': 'application/json;charset=utf-8',
[00:04:56]                   │ proc [kibana]       'content-length': '449'
[00:04:56]                   │ proc [kibana]     },
[00:04:56]                   │ proc [kibana]     meta: {
[00:04:56]                   │ proc [kibana]       context: null,
[00:04:56]                   │ proc [kibana]       request: [Object],
[00:04:56]                   │ proc [kibana]       name: 'elasticsearch-js',
[00:04:56]                   │ proc [kibana]       connection: [Object],
[00:04:56]                   │ proc [kibana]       attempts: 0,
[00:04:56]                   │ proc [kibana]       aborted: false
[00:04:56]                   │ proc [kibana]     }
[00:04:56]                   │ proc [kibana]   }
[00:04:56]                   │ proc [kibana] }
[00:04:56]                   │ proc [kibana]   log   [21:16:27.561] [warning][collector-set][plugins][usageCollection] Unable to fetch data from core collector
[00:04:56]                   │ proc [kibana]   log   [21:16:27.781] [warning][collector-set][plugins][usageCollection] ResponseError: search_phase_execution_exception
[00:04:56]                   │ proc [kibana]     at onBody (/dev/shm/workspace/kibana-build-xpack-12/node_modules/@elastic/elasticsearch/lib/Transport.js:333:23)
[00:04:56]                   │ proc [kibana]     at IncomingMessage.onEnd (/dev/shm/workspace/kibana-build-xpack-12/node_modules/@elastic/elasticsearch/lib/Transport.js:260:11)
[00:04:56]                   │ proc [kibana]     at IncomingMessage.emit (events.js:327:22)
[00:04:56]                   │ proc [kibana]     at endReadableNT (internal/streams/readable.js:1327:12)
[00:04:56]                   │ proc [kibana]     at processTicksAndRejections (internal/process/task_queues.js:80:21) {
[00:04:56]                   │ proc [kibana]   meta: {
[00:04:56]                   │ proc [kibana]     body: { error: [Object], status: 400 },
[00:04:56]                   │ proc [kibana]     statusCode: 400,
[00:04:56]                   │ proc [kibana]     headers: {
[00:04:56]                   │ proc [kibana]       'content-type': 'application/json;charset=utf-8',
[00:04:56]                   │ proc [kibana]       'content-length': '752'
[00:04:56]                   │ proc [kibana]     },
[00:04:56]                   │ proc [kibana]     meta: {
[00:04:56]                   │ proc [kibana]       context: null,
[00:04:56]                   │ proc [kibana]       request: [Object],
[00:04:56]                   │ proc [kibana]       name: 'elasticsearch-js',
[00:04:56]                   │ proc [kibana]       connection: [Object],
[00:04:56]                   │ proc [kibana]       attempts: 0,
[00:04:56]                   │ proc [kibana]       aborted: false
[00:04:56]                   │ proc [kibana]     }
[00:04:56]                   │ proc [kibana]   }
[00:04:56]                   │ proc [kibana] }
[00:04:56]                   │ proc [kibana]   log   [21:16:27.782] [warning][collector-set][plugins][usageCollection] Unable to fetch data from saved_objects_tagging collector
[00:04:56]                   │ proc [kibana]   log   [21:16:27.790] [info][savedobjects-service] [.kibana] INIT -> OUTDATED_DOCUMENTS_SEARCH
[00:04:56]                   │ proc [kibana]   log   [21:16:27.799] [info][savedobjects-service] [.kibana_task_manager] INIT -> CREATE_NEW_TARGET
[00:04:56]                   │ proc [kibana]   log   [21:16:27.803] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH -> UPDATE_TARGET_MAPPINGS
[00:04:56]                   │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] [.kibana_task_manager_8.0.0_001] creating index, cause [api], templates [], shards [1]/[1]
[00:04:57]                   │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] updating number_of_replicas to [0] for indices [.kibana_task_manager_8.0.0_001]
[00:04:57]                   │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] [.kibana_8.0.0_001/7kt76eNdS-CA4qlxxoFXwQ] update_mapping [_doc]
[00:04:57]                   │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_task_manager_8.0.0_001][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_task_manager_8.0.0_001][0]]"
[00:04:57]                   │ proc [kibana]   log   [21:16:27.887] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS -> UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK
[00:04:57]                   │ proc [kibana]   log   [21:16:27.888] [info][savedobjects-service] [.kibana_task_manager] CREATE_NEW_TARGET -> MARK_VERSION_INDEX_READY
[00:04:57]                   │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] 55314 finished with response BulkByScrollResponse[took=26.4ms,timed_out=false,sliceId=null,updated=31,created=0,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:04:57]                   │ proc [kibana]   log   [21:16:27.914] [info][savedobjects-service] [.kibana_task_manager] MARK_VERSION_INDEX_READY -> DONE
[00:04:57]                   │ proc [kibana]   log   [21:16:27.915] [info][savedobjects-service] [.kibana_task_manager] Migration completed after 134ms
[00:04:57]                   │ proc [kibana]   log   [21:16:27.994] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK -> DONE
[00:04:57]                   │ proc [kibana]   log   [21:16:27.994] [info][savedobjects-service] [.kibana] Migration completed after 215ms
[00:04:57]                   │ debg [saved_objects/spaces] Migrated Kibana index after loading Kibana data
[00:04:57]                   │ debg [saved_objects/spaces] Ensured that default space exists in .kibana
[00:04:57]                   │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-debian-tests-xxl-1614803094756144062] [.kibana_8.0.0_001/7kt76eNdS-CA4qlxxoFXwQ] update_mapping [_doc]
[00:04:58]                 └- ✖ fail: spaces api with security delete superuser from the space_1 space should return 204 when referencing the space_1 space explicitly in the URL
[00:04:58]                 │       Error: expected [ { key: 'default',
[00:04:58]                 │     doc_count: 8,
[00:04:58]                 │     countByType: 
[00:04:58]                 │      { doc_count_error_upper_bound: 0,
[00:04:58]                 │        sum_other_doc_count: 0,
[00:04:58]                 │        buckets: [Object] } },
[00:04:58]                 │   { key: 'space_1',
[00:04:58]                 │     doc_count: 7,
[00:04:58]                 │     countByType: 
[00:04:58]                 │      { doc_count_error_upper_bound: 0,
[00:04:58]                 │        sum_other_doc_count: 0,
[00:04:58]                 │        buckets: [Object] } } ] to sort of equal [ { key: 'default',
[00:04:58]                 │     doc_count: 9,
[00:04:58]                 │     countByType: 
[00:04:58]                 │      { doc_count_error_upper_bound: 0,
[00:04:58]                 │        sum_other_doc_count: 0,
[00:04:58]                 │        buckets: [Object] } },
[00:04:58]                 │   { doc_count: 7,
[00:04:58]                 │     key: 'space_1',
[00:04:58]                 │     countByType: 
[00:04:58]                 │      { doc_count_error_upper_bound: 0,
[00:04:58]                 │        sum_other_doc_count: 0,
[00:04:58]                 │        buckets: [Object] } } ]
[00:04:58]                 │       + expected - actual
[00:04:58]                 │ 
[00:04:58]                 │                  "key": "space"
[00:04:58]                 │                }
[00:04:58]                 │                {
[00:04:58]                 │                  "doc_count": 1
[00:04:58]                 │       +          "key": "config"
[00:04:58]                 │       +        }
[00:04:58]                 │       +        {
[00:04:58]                 │       +          "doc_count": 1
[00:04:58]                 │                  "key": "index-pattern"
[00:04:58]                 │                }
[00:04:58]                 │              ]
[00:04:58]                 │              "doc_count_error_upper_bound": 0
[00:04:58]                 │              "sum_other_doc_count": 0
[00:04:58]                 │            }
[00:04:58]                 │       -    "doc_count": 8
[00:04:58]                 │       +    "doc_count": 9
[00:04:58]                 │            "key": "default"
[00:04:58]                 │          }
[00:04:58]                 │          {
[00:04:58]                 │            "countByType": {
[00:04:58]                 │       
[00:04:58]                 │       at Assertion.assert (/dev/shm/workspace/parallel/12/kibana/packages/kbn-expect/expect.js:100:11)
[00:04:58]                 │       at Assertion.eql (/dev/shm/workspace/parallel/12/kibana/packages/kbn-expect/expect.js:244:8)
[00:04:58]                 │       at expectEmptyResult (test/spaces_api_integration/common/suites/delete.ts:133:24)
[00:04:58]                 │       at runMicrotasks (<anonymous>)
[00:04:58]                 │       at processTicksAndRejections (internal/process/task_queues.js:93:5)
[00:04:58]                 │ 
[00:04:58]                 │

Stack Trace

Error: expected [ { key: 'default',
    doc_count: 8,
    countByType: 
     { doc_count_error_upper_bound: 0,
       sum_other_doc_count: 0,
       buckets: [Object] } },
  { key: 'space_1',
    doc_count: 7,
    countByType: 
     { doc_count_error_upper_bound: 0,
       sum_other_doc_count: 0,
       buckets: [Object] } } ] to sort of equal [ { key: 'default',
    doc_count: 9,
    countByType: 
     { doc_count_error_upper_bound: 0,
       sum_other_doc_count: 0,
       buckets: [Object] } },
  { doc_count: 7,
    key: 'space_1',
    countByType: 
     { doc_count_error_upper_bound: 0,
       sum_other_doc_count: 0,
       buckets: [Object] } } ]
    at Assertion.assert (/dev/shm/workspace/parallel/12/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/12/kibana/packages/kbn-expect/expect.js:244:8)
    at expectEmptyResult (test/spaces_api_integration/common/suites/delete.ts:133:24)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5) {
  actual: '[\n' +
    '  {\n' +
    '    "countByType": {\n' +
    '      "buckets": [\n' +
    '        {\n' +
    '          "doc_count": 3\n' +
    '          "key": "visualization"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 2\n' +
    '          "key": "dashboard"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 2\n' +
    '          "key": "space"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "index-pattern"\n' +
    '        }\n' +
    '      ]\n' +
    '      "doc_count_error_upper_bound": 0\n' +
    '      "sum_other_doc_count": 0\n' +
    '    }\n' +
    '    "doc_count": 8\n' +
    '    "key": "default"\n' +
    '  }\n' +
    '  {\n' +
    '    "countByType": {\n' +
    '      "buckets": [\n' +
    '        {\n' +
    '          "doc_count": 3\n' +
    '          "key": "visualization"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 2\n' +
    '          "key": "dashboard"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "config"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "index-pattern"\n' +
    '        }\n' +
    '      ]\n' +
    '      "doc_count_error_upper_bound": 0\n' +
    '      "sum_other_doc_count": 0\n' +
    '    }\n' +
    '    "doc_count": 7\n' +
    '    "key": "space_1"\n' +
    '  }\n' +
    ']',
  expected: '[\n' +
    '  {\n' +
    '    "countByType": {\n' +
    '      "buckets": [\n' +
    '        {\n' +
    '          "doc_count": 3\n' +
    '          "key": "visualization"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 2\n' +
    '          "key": "dashboard"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 2\n' +
    '          "key": "space"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "config"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "index-pattern"\n' +
    '        }\n' +
    '      ]\n' +
    '      "doc_count_error_upper_bound": 0\n' +
    '      "sum_other_doc_count": 0\n' +
    '    }\n' +
    '    "doc_count": 9\n' +
    '    "key": "default"\n' +
    '  }\n' +
    '  {\n' +
    '    "countByType": {\n' +
    '      "buckets": [\n' +
    '        {\n' +
    '          "doc_count": 3\n' +
    '          "key": "visualization"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 2\n' +
    '          "key": "dashboard"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "config"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "index-pattern"\n' +
    '        }\n' +
    '      ]\n' +
    '      "doc_count_error_upper_bound": 0\n' +
    '      "sum_other_doc_count": 0\n' +
    '    }\n' +
    '    "doc_count": 7\n' +
    '    "key": "space_1"\n' +
    '  }\n' +
    ']',
  showDiff: true
}

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fileUpload 809.7KB 809.7KB -55.0B
maps 2.7MB 2.7MB +387.0B
total +332.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

thomasneirynck
thomasneirynck approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for closing the loop

@nreese nreese merged commit 05db7c6 into elastic:master Mar 4, 2021
@nreese nreese mentioned this pull request Mar 4, 2021
Merged
nreese added a commit to nreese/kibana that referenced this pull request Mar 4, 2021
@nreese
[Maps] Support GeometryCollections in GeoJson upload (elastic#93507)
f841ad3
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 4, 2021
@gmmorris
Merge branch 'master' into actions/terminology-api
55ff443 
* master: (107 commits)
  [Logs UI] Fix log stream data fetching (elastic#93201)
  [App Search] Added relevance tuning search preview (elastic#93054)
  [Canvas] Fix reports embeddables (elastic#93482)
  [ILM] Added new functional test in ILM for creating a new policy (elastic#92936)
  Remove direct dependency on statehood package (elastic#93592)
  [Maps] Track tile loading status (elastic#91585)
  [Discover][Doc] Improve main documentation (elastic#91854)
  [Upgrade Assistant] Disable UA and add prompt (elastic#92834)
  [Snapshot Restore] Remove cloud validation for slm policy (elastic#93609)
  [Maps] Support GeometryCollections in GeoJson upload (elastic#93507)
  [XY Charts] fix partial histogram endzones annotations (elastic#93091)
  [Core] Simplify context typings (elastic#93579)
  [Alerting] Improving health status check (elastic#93282)
  [Discover] Restore context documentation (elastic#90784)
  [core-docs] Edits core-intro section for the new docs system (elastic#93540)
  add missed codeowners (elastic#89714)
  fetch node labels via script execution (elastic#93225)
  [Security Solution] Adds getMockTheme function (elastic#92840)
  Sort dependencies in package.json correctly (elastic#93590)
  [Bug] missing timepicker:quickRanges migration (elastic#93409)
  ...
nreese added a commit that referenced this pull request Mar 4, 2021
@nreese
[Maps] Support GeometryCollections in GeoJson upload (#93507) (#93651)
f05493e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:fix v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maps] GeoJson file upload should support geometry-collections
4 participants
@nreese @elasticmachine @kibanamachine @thomasneirynck