-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintroduce 96111: Provide guidance of "Custom" allocation behavior in ILM #99007
Reintroduce 96111: Provide guidance of "Custom" allocation behavior in ILM #99007
Conversation
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
cc8ab94
to
ceb9ed9
Compare
…LM (elastic#96111)"" This reverts commit d40adb9.
…nents -> allocation_field.
0481b79
to
abdc58b
Compare
abdc58b
to
3548b6b
Compare
@cjcenizal turns out the length of the filenames isn't really the problem, it's the existence of the |
@spalger Terrific! Thank you for looking into this. I'll update this PR to simply revert the revert and leave the file names etc unchanged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert commit changes LGTM. Did not test locally.
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/feature_controls/time_to_visualize_security·ts.dashboard feature controls dashboard time to visualize security "before all" hook in "dashboard time to visualize security"Standard Out
Stack Trace
Kibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/feature_controls/time_to_visualize_security·ts.dashboard feature controls dashboard time to visualize security "after all" hook in "dashboard time to visualize security"Standard Out
Stack Trace
Kibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/discover/feature_controls/discover_security·ts.discover feature controls discover feature controls security "before all" hook in "discover feature controls security"Standard Out
Stack Trace
and 18 more failures, only showing the first 3. Metrics [docs]
History
To update your PR or re-run it, just comment with: |
We originally reverted #96111 because it looked like it was causing path length issues. I originally fixed this by reducing path length by 21 characters, by compressing the path
/data_tier_allocation_field/components
to/allocation_field
. Per Spencer's comment below, this turns out to be unnecessary so I've reverted those commits. This PR now simply reintroduces the original reverted PR.For release notes and screenshots please see the original PR: #96111