Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add robustness to avoid crashing on unexepected input #1250

Closed
colinsurprenant opened this issue Apr 10, 2014 · 7 comments
Closed

add robustness to avoid crashing on unexepected input #1250

colinsurprenant opened this issue Apr 10, 2014 · 7 comments

Comments

@colinsurprenant
Copy link
Contributor

this is a followup from issue #1240 - where pre multiline/tv_sec fix shippers were paired with post multiline/tv_sec fix indexers using redis. The indexer was crashing on the tv_sec error because the shipper malformed the event.

should we add robustness to avoid crashing in such a condition?

@colinsurprenant
Copy link
Contributor Author

also mentioned in https://logstash.jira.com/browse/LOGSTASH-1623

@colinsurprenant colinsurprenant changed the title evaluate if better robustness is required to avoid crashing on unexepected input add robustness to avoid crashing on unexepected input Apr 18, 2014
@colinsurprenant
Copy link
Contributor Author

@KlavsKlavsen
Copy link

I haven't looked into how exceptions are handled in logstash currently, so I'm just spitballing here :)

My feeling is, that handling exceptions needs to somehow be centralized - so it can be handled better once - and for all times. I'm sure you are better than me, at designing that in java :)

some sort of automatic exception handling that each input, output, filter etc. simply inherits (and can extend if need be), which does something default (and configurable) - like drop the line being worked on to a "failed lines" output - and then just skip and continue.

@suyograo
Copy link
Contributor

related to #2130 (comment)

@suyograo suyograo modified the milestones: 1.5.1, v1.5.0 Feb 26, 2015
@jsvd jsvd modified the milestones: v1.6.0, v1.5.1 Feb 26, 2015
@suyograo suyograo removed this from the v1.5.1 milestone May 15, 2015
@suyograo suyograo added v2.0.0 and removed v1.6.0 labels Sep 1, 2015
@suyograo suyograo removed the v2.0.0 label Sep 25, 2015
@colinsurprenant
Copy link
Contributor Author

the global exception handling issue is #2386 - I will keep this one open to make sure this specific concerned is tracked.

@colinsurprenant colinsurprenant removed their assignment Jan 13, 2016
@henriklynggaard
Copy link

Any traction on this. It has been open for a long time?

@colinsurprenant
Copy link
Contributor Author

I am closing this issue and redirecting to #4127. A lot a progress has been made to improve exception handling & reliability and the original issue reported here is not very current anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants