Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review LS startup to re-use expanded JRuby bits #12741

Closed
kares opened this issue Mar 10, 2021 · 1 comment
Closed

Review LS startup to re-use expanded JRuby bits #12741

kares opened this issue Mar 10, 2021 · 1 comment
Assignees

Comments

@kares
Copy link
Contributor

kares commented Mar 10, 2021

ATM, LS startup depends on jruby-complete.jar (which includes the Ruby stdlib) from logstash-core/lib/jars.
On the other hand, LS has an expanded JRuby installation located at vendor/jruby.

The JRuby installation includes the (core) vendor/jrubylib/jruby.jar and also the stdlib files, but LS is only using these for it's logstash-plugin management script.

This is confusing (run into this while trying to upgrade RubyGems - just to find out the files are not used on normal LS startup) and bin/logstash should rather re-use it's JRuby installation bits.


NOTE: this issue is blocking a potential easy resolution for #12077 (upgrading RGs to latest)

@kares
Copy link
Contributor Author

kares commented Feb 17, 2022

this landed in time for 8.1: #13159

@kares kares closed this as completed Feb 17, 2022
@kares kares added v8.1.0 and removed v8.0.0 labels Feb 17, 2022
@kares kares removed this from the 8.0.0 milestone Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant