Backport PR #16375 to 8.15: Exclude substitution refinement on pipelines.yml #16384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* Exclude substitution refinement on pipelines.yml (applies on ENV vars and logstash.yml where env2yaml saves vars) * Safety integration test for pipeline config.string contains ENV . (cherry picked from commit e104704)
|
CI failures are due to artifact not found: |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #16375 to 8.15 branch, original message:
Release notes
What does this PR do?
Continues a work of #16365 which fixed the bug of using array value with docker environment variables (such as
XPACK_MANAGEMENT_PIPELINE_ID,XPACK_MANAGEMENT_ELASTICSEARCH_HOSTS). However, ifconfig.stringcontains ${VAR}s substituted its origin value, refinement logic cleans up the quotes used on configs, for exampleoutput { elasticsearch { hosts => "my.host:9200"} },my.host:9200loses double quotes.With this PR, we are excluding
pipelines.ymland only applying refinement on ENV ${VAR}s.Why is it important/What is the impact to the user?
Users who are using
config.stringshould have a consistent user experience.Checklist
Author's Checklist
How to test this PR locally
config.stringinpipelines.ymlwith containing ${VAR} and es-output with hosts option.Related issues
Use cases
Screenshots
Logs