Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter and output threads arent named correctly #2425

Closed
ph opened this issue Jan 26, 2015 · 6 comments
Closed

Filter and output threads arent named correctly #2425

ph opened this issue Jan 26, 2015 · 6 comments
Assignees

Comments

@ph
Copy link
Contributor

ph commented Jan 26, 2015

Naming thread will help us debug problematic plugins.

4210 cashmol  20  0  9.804g 1.017g  15816 S 34.2 13.3  0:51.41 |worker

4209 cashmol  20  0  9.804g 1.017g  15816 S 32.2 13.3  0:50.56 |worker

4211 cashmol  20  0  9.804g 1.017g  15816 R 31.6 13.3  0:49.91 |worker

4212 cashmol  20  0  9.804g 1.017g  15816 S 30.9 13.3  0:49.18 |worker

i know they are filters.. but nobody knows which one

or 

4247 cashmol  20  0  9.804g 1.017g  15816 S  3.3 13.3  0:06.46 >output

4318 cashmol  20  0  9.804g 1.017g  15816 S  3.3 13.3  0:05.38 >output

4264 cashmol  20  0  9.804g 1.017g  15816 S  2.7 13.3  0:01.67 >output

https://github.com/elasticsearch/logstash/blob/master/lib/logstash/pipeline.rb#L196

@ph
Copy link
Contributor Author

ph commented Jan 26, 2015

cc @electrical

@purbon
Copy link
Contributor

purbon commented Jan 26, 2015

Agreed, this should be fix, it will simplify the debugging.

@suyograo suyograo assigned purbon and talevy and unassigned purbon Jan 27, 2015
@ph
Copy link
Contributor Author

ph commented Jan 27, 2015

After discussing with @talevy this isn't an easy fix to do for 1.5, we need to refactor the pipeline to do it in a clean way. Because one output thread consist of multiple plugins and some plugins can run in their own thread if workers > 1

But we both agreed that we need to give more visibility to user about what logstash is doing.

@ph
Copy link
Contributor Author

ph commented Jan 27, 2015

@jsvd this ticket should be included in the pipeline discussion.

@jsvd
Copy link
Member

jsvd commented Jan 27, 2015

noted 👍

@suyograo suyograo added this to the 2.0 milestone Jan 27, 2015
@suyograo suyograo added v2.0.0 and removed v2.0.0 labels Jun 18, 2015
@suyograo suyograo removed this from the v2.0.0 milestone Jun 18, 2015
@suyograo suyograo removed the v2.0.0 label Sep 25, 2015
@untergeek
Copy link
Member

This is moot now with the next generation pipeline, where filters and outputs are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants