Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to warn user on input/ouput not supporting codec #2845

Closed
wiibaa opened this issue Mar 18, 2015 · 2 comments
Closed

How to warn user on input/ouput not supporting codec #2845

wiibaa opened this issue Mar 18, 2015 · 2 comments

Comments

@wiibaa
Copy link
Contributor

wiibaa commented Mar 18, 2015

There are several plugins like http output or file output that do not use codecs but the configuration allows user to define it. But having an open issue is not enough visibility for users!
Should a method similar to workers_not_supported be added to the base.rb class ad called from the register method of the plugins lacking codec support or do you see another way ?

@ph
Copy link
Contributor

ph commented Mar 18, 2015

I agree this is a bad user experience :(

I think we should add another macro similar to the way were are defining the plugin config option.
The macros would alllow us to trap problems when we are parsing the config file (with or without using --configtest)

config :name, :validate => :string
workers_not_supported
codec_not_supported

def register
end

@suyograo suyograo added this to the v1.6.0 milestone Mar 18, 2015
@jordansissel jordansissel removed this from the v1.6.0 milestone Mar 19, 2015
@jordansissel
Copy link
Contributor

The way we are solving this (idealy, for 5.x) is to make codecs not a default property of all input and output plugins. That solution is in #4767.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants