Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong shutdown event object handling in plugins #2863

Closed
colinsurprenant opened this issue Mar 20, 2015 · 3 comments
Closed

wrong shutdown event object handling in plugins #2863

colinsurprenant opened this issue Mar 20, 2015 · 3 comments
Assignees

Comments

@colinsurprenant
Copy link
Contributor

while working on performance issues I discovered what is probably the source of the pipeline shutdown stalling regression in 1.5 we've been seeing.

The plugins are checking for LogStash::SHUTDOWN that is initialized as the :shutdown symbol while the pipeline pushes a LogStash::ShutdownEvent.new so the plugins never see the shutdown event.

The fix is currently in this commit c07368c which is part of the fix/perf_regression shared branch.

Once we merge that branch we'll have to release a new logstash-core version.

@colinsurprenant
Copy link
Contributor Author

fix included in the #2869 WIP PR

@colinsurprenant
Copy link
Contributor Author

@jsvd please take a look, as it explains the pipeline shutdown problems in 1.5

@colinsurprenant
Copy link
Contributor Author

this was closed by #2869

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants