Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception handling in plugins #3794

Closed
purbon opened this issue Aug 26, 2015 · 3 comments
Closed

Exception handling in plugins #3794

purbon opened this issue Aug 26, 2015 · 3 comments

Comments

@purbon
Copy link
Contributor

purbon commented Aug 26, 2015

Hi,
from the work I've been doing this days on adding test to plugins without I had the chance to revisit some of them, noticing an interesting pattern on them. Some plugins, use this pattern when handling exceptions:

   begin
     ....
   rescue Exception > e
      @logger.debug("...")
   end

even if this might makes sense for a first implementation of the plugin, so the plugin is not exploding when exceptions are thrown, I think we should improve the way we handle exceptions so we could do a fine granularity control. In some of the plugins there where situation when this exceptions hid errors that would be nice otherwise to notice.

Relates to #2477

@purbon
Copy link
Contributor Author

purbon commented Aug 26, 2015

@guyboertje your feedback is welcome

@colinsurprenant
Copy link
Contributor

This is a very important issue and lots of thinking and design has been already invested in this and we already have many issues opened around this and in particular #2386 and #2477 (as noted). Do we need to open a new meta issue for this? @jsvd?

This has to tie in with the new ongoing pipeline design and the shutdown work.

@purbon
Copy link
Contributor Author

purbon commented Aug 26, 2015

Closing this then as duplicate.

@purbon purbon closed this as completed Aug 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants