shutdown robustness and test tasks #2928
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| run_rspec(Rake::FileList["spec/**/*_spec.rb"]) | ||
| desc "run core specs" | ||
| task "core" => ["setup"] do | ||
| RSpec::Core::Runner.run([Rake::FileList["spec/**/*_spec.rb"]]) |
There was a problem hiding this comment.
@colinsurprenant please reapply the same exit code enforcement done in #2920 otherwise a failed "rake test" task will have an exit code of 0:
joaoduarte@Joaos-MBP-2 ~/projects/logstash (git)-[pr/2928] % bundle exec rake test:core
Using Accessor#strict_set for specs
Run options: exclude {:redis=>true, :socket=>true, :performance=>true, :couchdb=>true, :elasticsearch=>true, :elasticsearch_secure=>true, :broken=>true, :export_cypher=>true, :integration=>true, :windows=>true}
............................................................................................................................................................................................................................................F.........................................
Failures:
1) conditionals in filter simple "{"foo":"bar"}" when processed
Failure/Error: Unable to find matching line from backtrace
expected: "awesom"
got: "awesome"
(compared using ==)
# ./spec/core/conditionals_spec.rb:66:in `(root)'
# ./rakelib/test.rake:13:in `(root)'
Finished in 3.61 seconds
278 examples, 1 failure
Failed examples:
rspec ./vendor/bundle/jruby/1.9/gems/logstash-devutils-0.0.10-java/lib/logstash/devutils/rspec/logstash_helpers.rb:51 # conditionals in filter simple "{"foo":"bar"}" when processed
Randomized with seed 18354
joaoduarte@Joaos-MBP-2 ~/projects/logstash (git)-[pr/2928] % echo $?
0
There was a problem hiding this comment.
or rebase against master :-), good catch @jsvd
+1 on being sure we don't miss important stuff like this.
There was a problem hiding this comment.
yeah, did not rebase, I will.
colinsurprenant
force-pushed
the
fix/input_spec
branch
from
6cffdbb to
c36fad6
Compare
|
moved version bump in #2932 |
This was referenced Apr 1, 2015
|
LGTM (same for devutils and plugins) |
|
Dependent on #2949 |
suyograo
added a commit
to suyograo/logstash
that referenced
this pull request
Apr 7, 2015
|
LGTM, looked at devutils and all the plugins. |
|
I did a manual merge of this in 380ea33 |
|
All the plugins were pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactored test tasks and added robustness in shutdown handling and other thread safeties
this issue also relates to