Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track level telemetry devices #1224

Open
gingerwizard opened this issue Mar 29, 2021 · 1 comment
Open

Track level telemetry devices #1224

gingerwizard opened this issue Mar 29, 2021 · 1 comment
Labels
enhancement Improves the status quo :Telemetry Telemetry Devices that gather additional metrics

Comments

@gingerwizard
Copy link

We have seen cases where we need to collect telemetry statistics during the course of a track execution. For example, we might want to use previously collected metrics to compute a statistic - that can't be easily calculated in Kibana. For now, we do this work outside of the track.

Currently neither runners or param sources give us access to the metrics store. The proposal is to provide an interface, similar to that available for runners and param sources, where we can query and index into the metrics store - presumably this would be restricted to when es is enabled as the metrics store.

@danielmitterdorfer

@pquentin
Copy link
Member

When writing a new telemetry device, we need three steps:

  1. write to the metrics store (done in the actual telemetry device class)
  2. transform the data to aggregate it to appear in results as a single data point (done in GlobalStatsCalculator)
  3. print the results in the command line report by reading data from step 2 and format/compare them in a human-friendly way (done in SummaryReporter and ComparisonReporter)

This issue is only about 1. which is why @danielmitterdorfer opened #1314 for 2. and 3., but we see that we can't really dissociate the two issues, so with his blessing I'll close #1314 in favor of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :Telemetry Telemetry Devices that gather additional metrics
Projects
None yet
Development

No branches or pull requests

3 participants