Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'compare' should also show percentage diff #1328

Closed
b-deam opened this issue Sep 15, 2021 · 1 comment · Fixed by #1333
Closed

'compare' should also show percentage diff #1328

b-deam opened this issue Sep 15, 2021 · 1 comment · Fixed by #1333
Assignees
@b-deam
Labels
enhancement Improves the status quo :Reporting Command line reporting :Usability Makes Rally easier to use

Comments

@b-deam
Copy link
Member

b-deam commented Sep 15, 2021

When we compare two races it'd be nice to also get a column in the resulting table showing the +/- % difference between each metric for easier comparison, e.g

esrally compare --baseline b7418ff8-0e4a-4b27-b6f6-226524c313da --contender a4af31ef-076d-4c60-8d6e-3dc5aa4880a4

...

------------------------------------------------------
    _______             __   _____
   / ____(_)___  ____ _/ /  / ___/_________  ________
  / /_  / / __ \/ __ `/ /   \__ \/ ___/ __ \/ ___/ _ \
 / __/ / / / / / /_/ / /   ___/ / /__/ /_/ / /  /  __/
/_/   /_/_/ /_/\__,_/_/   /____/\___/\____/_/   \___/
------------------------------------------------------

|                                                        Metric |                                                 Task |    Baseline |   Contender |     Diff |   Unit | % Diff |
|--------------------------------------------------------------:|-----------------------------------------------------:|------------:|------------:|---------:|-------:|--------:
....
|                                       50th percentile latency |   range_field_disjunction_big_range_small_term_query |     141.781 |     781.116 |  639.335 |     ms | +453%
....
|                                  90th percentile service time | range_field_disjunction_small_range_small_term_query |     59.6564 |     53.9495 | -5.70696 |     ms | -9.5%


-------------------------------
[INFO] SUCCESS (took 3 seconds)
-------------------------------
@b-deam b-deam added enhancement Improves the status quo :Metrics How metrics are stored, calculated or aggregated :Usability Makes Rally easier to use labels Sep 15, 2021
@b-deam b-deam self-assigned this Sep 15, 2021
@pquentin
Copy link
Member

Excellent idea!

Going one step further, we could also only color results when the difference is statistically significant.

@b-deam b-deam added :Reporting Command line reporting and removed :Metrics How metrics are stored, calculated or aggregated labels Sep 16, 2021
@b-deam b-deam mentioned this issue Sep 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@b-deam b-deam

Labels
enhancement Improves the status quo :Reporting Command line reporting :Usability Makes Rally easier to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add percentage diff column to compare subcommand b-deam/rally
2 participants
@pquentin @b-deam