From 034c725831ac986de9392f165fbcbaf5df1d07dd Mon Sep 17 00:00:00 2001 From: Daniel Mitterdorfer Date: Tue, 14 Apr 2020 10:54:41 +0200 Subject: [PATCH 1/2] Selectively disable docstring linter check With this commit we selectively disable a linter check for invalid docstring quotes as this causes CI failures sometimes but without being reproducible outside of CI. --- esrally/version.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/esrally/version.py b/esrally/version.py index 90899e10e..9c6783577 100644 --- a/esrally/version.py +++ b/esrally/version.py @@ -42,6 +42,8 @@ def revision(): def version(): + # Disabled not because this is an actual issue here but it is occasionally reported by pylint in CI. + # pylint:disable=invalid-docstring-quote """ :return: The release version string and an optional suffix for the current git revision if Rally is installed in development mode. """ From eaec48250f8ee01b66d5f865916c9abc9809cd3a Mon Sep 17 00:00:00 2001 From: Daniel Mitterdorfer Date: Tue, 14 Apr 2020 11:05:04 +0200 Subject: [PATCH 2/2] Disable globally --- .pylintrc | 3 ++- esrally/version.py | 2 -- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.pylintrc b/.pylintrc index 5a50b1213..eea9a6cfb 100644 --- a/.pylintrc +++ b/.pylintrc @@ -191,7 +191,8 @@ disable=print-statement, W0404, W0612, W0613, - W0621 + W0621, + invalid-docstring-quote # Enable the message, report, category or checker with the given id(s). You can diff --git a/esrally/version.py b/esrally/version.py index 9c6783577..90899e10e 100644 --- a/esrally/version.py +++ b/esrally/version.py @@ -42,8 +42,6 @@ def revision(): def version(): - # Disabled not because this is an actual issue here but it is occasionally reported by pylint in CI. - # pylint:disable=invalid-docstring-quote """ :return: The release version string and an optional suffix for the current git revision if Rally is installed in development mode. """