Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I'd like for filters NOT to reset when search term changes #292

Closed
FokkeZB opened this issue Jun 27, 2019 · 3 comments
Closed

I'd like for filters NOT to reset when search term changes #292

FokkeZB opened this issue Jun 27, 2019 · 3 comments

Comments

@FokkeZB
Copy link
Contributor

FokkeZB commented Jun 27, 2019

Currently, when you change the search term - you'll lose all filters.

I'm not sure if that is a bug or a feature, but I find it annoying if you'd like to make your terms more specific to narrow down results. I'd like to at least have the option to keep the filters.

Reproduce

  1. Open https://search-ui-stable.netlify.com/?q=Death&size=n_20_n&filters%5B0%5D%5Bfield%5D=states&filters%5B0%5D%5Bvalues%5D%5B0%5D=California&filters%5B0%5D%5Btype%5D=any
  2. Notice the filter on California
  3. Change the search term to Yosemite
  4. Notice the filter is gone
@JasonStoltz
Copy link
Member

@FokkeZB That is as designed, as this is typical of most search experiences. I have an issue in the backlog about providing an option to make filters "sticky", so that they do not get reset. Does this makes sense to you? #89

I'm going to close this issue for now, let's move the discussion to #89.

@johanarnor
Copy link
Contributor

For those who find this issue and think that it hasn't been implemented yet (like me) - check the docs! It's been implemented since #391

@JasonStoltz
Copy link
Member

Good point @johanarnor, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants