Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serverless] Document impact of using logsDB for security users #6221

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Nov 21, 2024

Partially addresses #5864 by providing Serverless docs.

Previews:

@nastasha-solomon nastasha-solomon added backport-skip Feature: Alerts Feature: Rules Team: Detection Engine Effort: Medium Issues that take moderate but not substantial time to complete Priority: Urgent Issues that need to be resolved as soon as possible Docset: Serverless Issues for Serverless Security labels Nov 21, 2024
@nastasha-solomon nastasha-solomon self-assigned this Nov 21, 2024
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@jmikell821 jmikell821 marked this pull request as ready for review November 22, 2024 19:13
@jmikell821 jmikell821 requested a review from a team as a code owner November 22, 2024 19:13

While we do not recommend using `_source` for actions, in cases where the action relies on the `_source`, the same limitations and changes apply.

If you send alert notifications by enabling {kibana-ref}/alerting-getting-started.html#alerting-concepts-actions[actions], and then have logic outside of {sec-serverless} based on fields formatted from the original source, those flows may be affected. In particular, affected fields would be an array of objects.
Copy link
Contributor

@jmikell821 jmikell821 Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole paragraph is a little confusing to me and I'm not 100% sure what it means. Is there any way we could break this down into simpler terms? For example, what does and then have logic outside of {sec-serverless} based on fields formatted from the original source, those flows may be affected mean?

Copy link
Contributor

@approksiu approksiu Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like this: "If you send alert notifications by enabling {kibana-ref}/alerting-getting-started.html#alerting-concepts-actions[actions] to the external systems that have workflows or automations based on fields formatted from the original source, they may be affected. In particular, this can happen when the fields used are arrays of objects."

approksiu
approksiu previously approved these changes Nov 26, 2024
Copy link
Contributor

@approksiu approksiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, and the rest looks good to me! Thanks a lot!

Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few slight suggestions, thanks!

docs/serverless/rules/detections-logsdb-impact.asciidoc Outdated Show resolved Hide resolved
docs/serverless/rules/detections-logsdb-impact.asciidoc Outdated Show resolved Hide resolved
docs/serverless/rules/detections-logsdb-impact.asciidoc Outdated Show resolved Hide resolved
nastasha-solomon and others added 3 commits November 26, 2024 16:57
Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
@yctercero yctercero self-requested a review November 27, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Docset: Serverless Issues for Serverless Security Effort: Medium Issues that take moderate but not substantial time to complete Feature: Alerts Feature: Rules Priority: Urgent Issues that need to be resolved as soon as possible Team: Detection Engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants