-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Time based OTP #957
Conversation
040ad2f
to
bad0642
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
6ec81a0
to
4a3d095
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 1.14.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
@vigneshshanmugam @shahzad31 can you please confirm if this release will only be available in |
@vigneshshanmugam There is discrepancy about the script below mfa.token const token = mfa.token(params.MFA_GH_SECRET) It should be const token = mfa.totp(params.MFA_GH_SECRET) Can you please review? |
@kvesthy Good catch, Sent out a fix to the docs. Thank you. |
otpauth
. Its actively maintained and works on all runtimes.mfa.totp
function that can be used to generate a One time token during the journey run.