Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: interactive scaffolding for picking default monitor config #508

Merged

Conversation

vigneshshanmugam
Copy link
Member

@vigneshshanmugam vigneshshanmugam commented May 23, 2022

  • fix https://github.com/elastic/synthetics-dev/issues/119
  • part of Push command final touchup before release  #513
  • init command scaffolding asks interactive questions for both Locations and Schedule which would be set as default on the Synthetics.config.ts file to be used when pushing the monitors.
  • Error out when push command is invoked without passing the journey file paths
  • Make the location and schedule option as required --locations <> in the CLI and error out when not set.
  • Allow users to configure the default values via synthetics.config.ts file

How to test

  1. Build the agent npm run build
  2. Run node dist/cli.js init test-directory
  3. Verify if it sets up all the default schedule and locations in the synthetics.config.ts generated file.

@apmmachine
Copy link

apmmachine commented May 23, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-02T23:47:00.019+0000

  • Duration: 14 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 164
Skipped 2
Total 166

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@vigneshshanmugam vigneshshanmugam changed the title fix: mark location and journey paths as mandatory feat: interactive scaffolding for picking default monitor config Jun 2, 2022
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

__tests__/push/index.test.ts Outdated Show resolved Hide resolved
__tests__/push/index.test.ts Outdated Show resolved Hide resolved
src/cli.ts Outdated Show resolved Hide resolved
Co-authored-by: Andrew Cholakian <andrew@andrewvc.com>
@vigneshshanmugam vigneshshanmugam merged commit a4c10b5 into elastic:main Jun 3, 2022
@vigneshshanmugam vigneshshanmugam deleted the required-arg-optioons branch June 3, 2022 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants