Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: write .gitnore files for scaffolding #510

Merged
merged 1 commit into from
May 25, 2022

Conversation

vigneshshanmugam
Copy link
Member

@apmmachine
Copy link

apmmachine commented May 24, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-24T17:42:56.880+0000

  • Duration: 12 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 161
Skipped 2
Total 163

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@lucasfcosta lucasfcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vigneshshanmugam I did just test again locally and it works. I've also checked NPM docs to be sure that the root cause analysis was 100% correct.

I also found this: npm/npm#3763. Apparently we could also just add an .npmignore to prevent the .gitignore from being moved as .npmignore.

However, the ultimate test here would be to deploy that to NPM and check whether it works there too 😄 Can we do a release under a beta tag to try this one out btw?

@@ -1,2 +0,0 @@
node_modules
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's funny that the template .gitignore was ignored itself and thus we had this bug 😆

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly :lol , which is why I am not using the file from here and instead writing when setting up the package which would eliminate the dependency on the NPM letting us use dot files.

@vigneshshanmugam
Copy link
Member Author

However, the ultimate test here would be to deploy that to NPM and check whether it works there too 😄 Can we do a release under a beta tag to try this one out btw?

We publish everything under beta as we are in the Beta stage. So should be good here.

@vigneshshanmugam vigneshshanmugam merged commit 1306c55 into elastic:main May 25, 2022
@vigneshshanmugam vigneshshanmugam deleted the remove-gitignore branch May 25, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synthetics init fails because templates weren't included in distributable
3 participants