Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use fixed playwright version #540

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

vigneshshanmugam
Copy link
Member

  • Broken by the PW upgrade - fix: update to the latest playwright #485, we have always used to fix the version of PW and reduce the breakage footprint that comes with new versions which might have new system dependencies.
  • Without this zip urls monitors that uses the latest version of the Synthetics package will install PW versions that are the latest version 1.23.0 that also requires other system dependencies and fails to invoke the Synthetics.

Produces validation errors like this.

 Host system is missing dependencies to run browsers

║ Please install them with the following command: ║
║ sudo npx playwright install-deps ║
║ Alternatively, use apt: ║
║ sudo apt-get install libwayland-client0 ║

@apmmachine
Copy link

apmmachine commented Jun 27, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-28T00:54:01.673+0000

  • Duration: 14 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 167
Skipped 2
Total 169

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@andrewvc
Copy link
Contributor

I'm not sure that goes back far enough. I tested that version of playwright by running the current todos demo with a modified package.json shown below in a heartbeat:7.3.0-SNAPSHOT container

{
  "name": "todos",
  "private": true,
  "description": "This suite tests the examples that ship with the open source Vue.js project.",
  "scripts": {},
  "license": "MIT",
  "dependencies": {
    "@elastic/synthetics": "*",
    "playwright-core": "=1.20.1"
  },
  "devDependencies": {
    "node-static": "^0.7.11"
  }
}

I still got the error:


heartbeat@2bc283fe3c0f:/tmp/synthetics-demo/todos/synthetics-tests$ npx @elastic/synthetics .
browserType.launch:
╔══════════════════════════════════════════════════════╗
║ Host system is missing dependencies to run browsers. ║
║ Please install them with the following command:      ║
║                                                      ║
║     sudo npx playwright install-deps                 ║
║                                                      ║
║ Alternatively, use apt:                              ║
║     sudo apt-get install libwayland-client0          ║
║                                                      ║
║ <3 Playwright Team                                   ║
╚══════════════════════════════════════════════════════╝

Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pinning both core and chromium fixed it

@vigneshshanmugam vigneshshanmugam merged commit 4879742 into elastic:main Jun 28, 2022
@vigneshshanmugam vigneshshanmugam deleted the fix-pw-version branch June 28, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants