-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: abort push on duplicate monitors #568
feat: abort push on duplicate monitors #568
Conversation
|
||
import { journey, monitor } from '../../src'; | ||
|
||
journey('journey 1', () => monitor.use({ id: 'duplicate' })); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since names are used as ids in the absense of id
, can we add two monitors with the same name to this fixture as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh good callout, sure will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done - 4b3837a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested four scenarios
- Two monitors with the same id configured via
monitor.use
- Two monitors with the same id configure via journey options
- Two monitors with the same name without id configured via the other two options
- Two monitors, one with an id specified, one without an id specified, where the name of the former and the id of the latter are the same.
Testing.