Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse buffered NDJSON response from kibana correctly #665

Merged

Conversation

vigneshshanmugam
Copy link
Member

@vigneshshanmugam vigneshshanmugam commented Nov 28, 2022

  • fix Ndjson parsing is broken if data is bit large  #660
  • When Kibana NDJSON responses are buffered, this would result in parsing error on the chunking code as buffer length can be different when working on local vs on cloud (proxies).
  • To account for these varying buffer lengths, We consume all the stream body from Kibana as buffers and then parse the NDJSON response to avoid intereleaved parsing errors.

@apmmachine
Copy link

apmmachine commented Nov 28, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-28T23:51:49.693+0000

  • Duration: 14 min 42 sec

Test stats 🧪

Test Results
Failed 0
Passed 203
Skipped 2
Total 205

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@shahzad31
Copy link
Contributor

Tested against cloud cluster and it works as expected

image

@vigneshshanmugam vigneshshanmugam merged commit 1231557 into elastic:main Nov 29, 2022
@vigneshshanmugam vigneshshanmugam deleted the fix-buffered-response branch November 29, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ndjson parsing is broken if data is bit large
3 participants