Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prompt before overriding config file #688

Merged
merged 1 commit into from
Jan 17, 2023
Merged

feat: prompt before overriding config file #688

merged 1 commit into from
Jan 17, 2023

Conversation

vigneshshanmugam
Copy link
Member

  • fix Prompt for overwriting files on existing scaffolded projects #680
  • This prompts the user before overwriting the existing synthetics.config.file.
  • For the package.json - It will not be overwritten when the init is run multiple times
    • npm init -y process will skip the package.json installation if there is already a package.json file.
    • Our patching logic will only modify the existing file if the test or push script is not defined. Safe operation.
  • For .gitignore - We overwrite only if the node_modules or .synthetics is not present - Safe operation.

@vigneshshanmugam vigneshshanmugam changed the title chore: prompt before overriding config file feat: prompt before overriding config file Dec 28, 2022
@apmmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-28T00:50:00.535+0000

  • Duration: 16 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 206
Skipped 2
Total 208

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@vigneshshanmugam vigneshshanmugam mentioned this pull request Dec 28, 2022
Merged
colleenmcginnis added a commit to colleenmcginnis/observability-docs that referenced this pull request Jan 5, 2023
@colleenmcginnis
add notes based on elastic/synthetics#688
2c23e9e
colleenmcginnis added a commit to elastic/observability-docs that referenced this pull request Jan 11, 2023
@colleenmcginnis
[synthetics] Document migrating from the Synthetics Integration (#2445)
3a64ba6 
* intiial files

* remove heartbeat migration guide for now

* build out text

* apply @paulb-elastic's suggestions

* add info about using init to upgrade an existing project

* add notes based on elastic/synthetics#688

* clarify how package.json is modified
mergify bot pushed a commit to elastic/observability-docs that referenced this pull request Jan 11, 2023
@colleenmcginnis @mergify
[synthetics] Document migrating from the Synthetics Integration (#2445)
208befd 
* intiial files

* remove heartbeat migration guide for now

* build out text

* apply @paulb-elastic's suggestions

* add info about using init to upgrade an existing project

* add notes based on elastic/synthetics#688

* clarify how package.json is modified

(cherry picked from commit 3a64ba6)
colleenmcginnis added a commit to elastic/observability-docs that referenced this pull request Jan 11, 2023
@mergify @colleenmcginnis
[synthetics] Document migrating from the Synthetics Integration (#2445)…
9c343e6 
… (#2501)

* intiial files

* remove heartbeat migration guide for now

* build out text

* apply @paulb-elastic's suggestions

* add info about using init to upgrade an existing project

* add notes based on elastic/synthetics#688

* clarify how package.json is modified

(cherry picked from commit 3a64ba6)

Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co>
andrewvc
andrewvc approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vigneshshanmugam vigneshshanmugam merged commit 3607820 into elastic:main Jan 17, 2023
@vigneshshanmugam vigneshshanmugam deleted the warn-override branch January 17, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewvc andrewvc andrewvc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prompt for overwriting files on existing scaffolded projects
3 participants
@vigneshshanmugam @apmmachine @andrewvc