Don't force resource replacement when expiration is unset during SDK-PF migration #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobio
force-pushed
the
api-key-expiration
branch
3 times, most recently
from
ffaead5
to
ac6dc62
Compare
tobio
force-pushed
the
api-key-expiration
branch
from
ac6dc62
to
12df04b
Compare
wandergeek
approved these changes
Oct 25, 2024
kjwardy
pushed a commit
to kjwardy/terraform-provider-elasticstack
that referenced
this pull request
Nov 19, 2024
…PF migration (elastic#875) * Don't force resource replacement when expiration is unset during SDK-PF migratino * CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK based api_key resources stored
expiration:""in state when it's unset in config, however PF based resources more specifically model this asnull. This is causing TF to force the replacement of API Keys when upgrading from 0.11.10.This PR updates the RequiresReplace logic to only require replacement when the expiration value actually changes (e.g
1d->null). It also adds an acceptance test verifying provider behaviour during the migration from SDK->PF, specifically that the underlying API Key is not replaced.Fixes #873