Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connections that are not instances on net.TCPConn are not closed properly #270

Closed
jasonzimmerman opened this issue Jan 27, 2018 · 1 comment
Closed

Connections that are not instances on net.TCPConn are not closed properly #270

jasonzimmerman opened this issue Jan 27, 2018 · 1 comment

Comments

@jasonzimmerman
Copy link

When using a Dialer that does not return net.Conn or net.TCPConn, connections are not closed properly when making an HTTP CONNECT request. This seems to stem from https.go:113. It seems like the code is waiting for both connections to be closed before closing both connections.
@ErikPelli ErikPelli mentioned this issue Dec 20, 2024
Closed
@ErikPelli
Copy link
Collaborator

Currently, in this case, a normal close is used, thanks to #585. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasonzimmerman @ErikPelli