Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy Support #41

Closed
deldrid1 opened this issue Apr 3, 2018 · 2 comments
Closed

Proxy Support #41

deldrid1 opened this issue Apr 3, 2018 · 2 comments
Assignees

Comments

@deldrid1
Copy link

deldrid1 commented Apr 3, 2018

Can builder support the use of a proxy server (on windows)?

request.js seems to support this use case out of the box: https://github.com/request/request#controlling-proxy-behaviour-using-environment-variables

However, I’m not positive that github@0.2.4: (which has now been renamed to '@octokit/rest' https://git.io/vNB11) is respecting proxies correctly per https://github.com/octokit/rest.js/issues/770 and I think it might need to be updated? Ideally, it would support respecting HTTP_PROXY and HTTPS_PROXY environment variables…

Node.js’s decision to not go down the “slippery slope” of supporting proxy servers in the core (nodejs/node#15620) makes things much more difficult then they need to be… Unfortunately, I can confirm that Proxy support is not working currently...

@ppetrosh ppetrosh self-assigned this Apr 4, 2018
@ppetrosh
Copy link
Contributor

ppetrosh commented Apr 5, 2018

Working on this one now... should be ready by the end of the week or early next week.

@ppetrosh
Copy link
Contributor

ppetrosh commented Apr 9, 2018

Fixed.

@ppetrosh ppetrosh closed this as completed Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants