-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(loading spinner): optimize loading spinner and inline code + css animation #6821
perf(loading spinner): optimize loading spinner and inline code + css animation #6821
Conversation
@tonypls if you think this works better feel free to merge this instead 🙂 |
Maybe @Alportan can confirm the animation is perfect? Testing instructions, open dev tools, click on network tab, set throttling to fast 3G, reload tab and watch the spinner spin |
The animation looks good 🙌 Maybe a small small thing, more regarding the logo SVG itself (*puts brand police cap on ⚡️👮♂️🚨), the zap in the middle seems a tiny bit bigger than the one we use in the logo asset. By far a nitpick and not a blocker to this PR 😅 🙈 ☝️ I overlayed my asset on the screenshot of the spinner 🙌 |
Well that's awkward as I copied the one we use for the favicon and animated that (it had cleaner proportions). |
Haha, I don't know about the favicon, but I can definitely provide the SVGs. I've attached them here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Minor comment, otherwise LGTM
Description
Same as #6819 but uses CSS for the animation instead. Looks to be quicker than the animate elements in the code.
Closes: #6819
Double check
pnpx prettier@2 --write .
andpoetry run format
in the top level directory to format my changes.