-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): handle historcal linking with basic navigation #7397
feat(web): handle historcal linking with basic navigation #7397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some early comments, but the only thing I would require a change of is the url handling so it supports upper case as well and to use the Intl formatRange function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@cadeban I noticed some inconsistency in the navigation logic so I simplified it! Could ya please review the last commit? |
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 11 changed files in this pull request and generated 1 suggestion.
Files not reviewed (6)
- web/src/components/Time.tsx: Evaluated as low risk
- web/src/features/time/HistoricalTimeHeader.tsx: Evaluated as low risk
- web/src/features/time/TimeController.tsx: Evaluated as low risk
- web/src/utils/formatting.ts: Evaluated as low risk
- web/src/utils/state/atoms.ts: Evaluated as low risk
- web/cypress/e2e/ranking.spec.ts: Evaluated as low risk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Hey Viktor, have your requested changes been addressed? |
Issue
View historical data with hourly granularity
Description
Currently behind the feature flag
historical-linking
This PR updates the state and zone requests to be able to query historical data at at hourly granularity and some basic navigation between time windows.
The navigation currently going back to the more recent utc 00:00 hour for the first click and subtracts 24 hours from there.
In the spirit of deploying early and often I'd like to release this behind the feature flag and get it in the hands of our test users asap for feedback.