chore(SEO): Sanitze zone names in URL #7407
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
In some online platforms when you write a link like this https://app.electricitymaps.com/DK-DK1: Denmark, the colon is included which breaks the links. Similar problems can occur with (https://app.electricitymaps.com/DK-DK2) causing the trailing parentheses to be included in the link.
Description
In order to avoid this I added a regex that only allows the zoneID to contain, letters, numbers and
-
which we use as a subzone delimiter. This should resolve the issue quite nicely.I also took to opportunity to clean up the code a bit so it handles more things internally and not potentially causing multiple navigations requests. So instead of going
aus -> AUS -> AU
it simply goesaus -> AU
.Double check
pnpx prettier@2 --write .
andpoetry run format
in the top level directory to format my changes.