Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fruit(web): update US translations with SEO friendly zone names #7408

Merged
merged 9 commits into from
Nov 14, 2024

Conversation

tonypls
Copy link
Collaborator

@tonypls tonypls commented Nov 13, 2024

Issue

It's not always clear what zone is what in search results

Description

This PR updates some US zone page meta titles to include full SEO zone names.

Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things but otherwise it looks good!

Probably going to take a while for Google to catch on though.

web/src/locales/en.json Outdated Show resolved Hide resolved
web/src/translation/translation.ts Show resolved Hide resolved
Co-authored-by: Viktor Andersson <30777521+VIKTORVAV99@users.noreply.github.com>
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@VIKTORVAV99
Copy link
Member

Can we also change New England ISO to ISO New England https://staging.electricitymaps.com/zone/US-NE-ISNE/24h, this would then match their official naming:
image

The abbreviation should be ISO-NE

@VIKTORVAV99
Copy link
Member

@tonypls can you also update the zoneNames in the file the API uses?

Should be in /public/ instead.

@tonypls tonypls merged commit e75890a into master Nov 14, 2024
23 checks passed
@tonypls tonypls deleted the tvs/low-hanging-fruit-US-SEO branch November 14, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants