Missing Squirrel Config information - Icon

[mix3d]

https://js.electronforge.io/maker/squirrel/interfaces/makersquirrelconfig#iconurl
This references iconUrl, but not icon.

Because iconUrl expects a remote http/https url string, builds will fail when pointed to a local file.
see: electron-userland/electron-installer-windows#55 (comment)

This should note that only one of [iconUrl, icon] should be used, and icon for local app icon files.

[malept]

electron-installer-windows isn't used in Electron Forge, electron-winstaller is.

[mix3d]

Then why was my app still failing to build when I was using iconUrl with a local path?
iconUrl: "./assets/app.ico"

"Invalid URI: The format of the URI could not be determined."

If I try iconUrl: "file://./assets/app.ico", I get

The 'http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd:iconUrl' element is invalid - The value 'file://./assets/app.ico' is invalid according to its datatype 'http://www.w3.org/2001/XMLSchema:anyURI' - The string 'file://./assets/app.ico' is not a valid Uri value.

[malept]

iconUrl is described here: https://github.com/Squirrel/Squirrel.Windows/blob/de5baa93a134ac24fd5bf9172d3e457ac27e0b7a/docs/using/nuget-package-metadata.md#L15

[mix3d]

Then I would suggest including the very much important bit of information:

"Note that the icon is fetched at installation time rather than packaging"

thus requiring this to be a fully qualified URL publicly available.

[malept]

I think you're looking for setupIcon: https://github.com/electron/windows-installer#usage

Also https://js.electronforge.io/maker/squirrel/interfaces/makersquirrelconfig#setupicon

[mix3d]

Nope, I am looking for the icon for the application itself, that is displayed on the EXE and in the installed application menu.

Without an iconUrl, I get the default app icon on install:

What your Squirrel.Windows link says, is that it is grabbed at installation time, which means (unless I'm reading it wrong) it needs to be a fully qualified URL and accessible via internet. (Which is honestly REALLY annoying for offline installs)

See:
electron/windows-installer#151
electron/windows-installer#56

[malept]

(Which is honestly REALLY annoying for offline installs)

Perhaps you want the WiX MSI maker instead.

[mix3d]

Either way, I would strongly encourage the docs to reflect this strict publicly hosted URL requirement.

[malept]

Feel free to submit a pull request to adjust the docs here: https://github.com/electron/windows-installer/blob/ce04bd0e13872d9a8cf7c7a507949c53a6732dfc/src/options.ts#L82-L87