Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuilding native dependencies ignores non-gyp modules #3938

Closed
Julusian opened this issue Jun 3, 2019 · 1 comment
Closed

Rebuilding native dependencies ignores non-gyp modules #3938

Julusian opened this issue Jun 3, 2019 · 1 comment
Labels

Comments

@Julusian
Copy link
Contributor

Julusian commented Jun 3, 2019

  • Version: 20.15.0
  • Target: windows 10 x64

During the rebuild phase, only gyp based native dependencies are being considered and rebuilt. This means that some don't get rebuilt and then fail to load at runtime.

This following line is what is at fault, in assuming that nativeDeps will have a binding.gyp

const nativeDeps = await BluebirdPromise.filter(await options.productionDeps!.value, it => exists(path.join(it.path, "binding.gyp")), {concurrency: 8})

It can be tricked it into rebuilding a cmake-js based dependency by adding an empty binding.gyp file to the package, but that is a hacky workaround.

@stale
Copy link

stale bot commented Aug 2, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant