Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update workflow dependencies #202

Merged
merged 10 commits into from
Jun 26, 2024
Merged

ci: update workflow dependencies #202

merged 10 commits into from
Jun 26, 2024

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Jun 21, 2024 •
edited
Loading

This fixes CI by:

  • Upgrading nan to 2.20.0 (ref chore: overload deprecated AccessorSignatures nodejs/nan#943)
  • Pinning Python to 3.11 in the action.
  • Dropping CI for Node.js 12 and Node.js 14 in preparation for a breaking change. This made it easier for tests to pass since older versions of Python were required for the versions of node-gyp that support Node 12 and 14, and those weren't available via actions/setup-python.

@erickzhao erickzhao changed the title wip build: fix CI Jun 22, 2024
@erickzhao erickzhao changed the title build: fix CI ci: update workflow dependencies Jun 22, 2024
@erickzhao erickzhao requested a review from a team June 22, 2024 04:42
@erickzhao erickzhao merged commit 4fc4910 into main Jun 26, 2024
4 checks passed
@erickzhao erickzhao deleted the make-ci branch June 26, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsanders11 dsanders11 dsanders11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erickzhao @dsanders11