Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split meson:electron into 2 parts to eliminate dev dependencies from build #84

Open
rdickert opened this issue May 11, 2016 · 0 comments

Comments

@rdickert
Copy link
Contributor

We are having trouble building our Meteor app on production the meson:electron. We are getting this error:

Errors prevented bundling:
While linking the program:
error: meson:electron is not compatible with architecture 'os.linux.x86_64'".  

The issue is that the webservers are linux so the build command is meteor build --architecture os.linux.x86_64 latestBuild.

It seems likely that it is the electron build tools that are causing this. What if we split meson:electron into two parts:

  1. App: Includes client/index.js, the app dir, and app update server logic (routing etc.). Build in all environments.
  2. Dev tools: Includes Electron build infrastructure and reload code. Use the debugOnly flag so it doesn't build in production. For people with unusual build situations, they could also choose to remove the dev package manually.

This would decouple dev environments from deployment. Alternatively, is there a solution to this without any changes to the package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant