From 8ffab0b44527bd274b0f0d646786fef55a2bfcf4 Mon Sep 17 00:00:00 2001 From: Mark Lee Date: Fri, 4 May 2018 02:59:53 -0700 Subject: [PATCH] fix(publisher-github): remove deprecated option from @octokit/rest params (#505) This broke with @octokit/rest.js 15.2.0. ISSUES CLOSED: #493 --- packages/publisher/github/src/util/github.ts | 1 - packages/publisher/github/test/github_spec.ts | 9 ++------- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/packages/publisher/github/src/util/github.ts b/packages/publisher/github/src/util/github.ts index 043a209da0..88e4f2f985 100644 --- a/packages/publisher/github/src/util/github.ts +++ b/packages/publisher/github/src/util/github.ts @@ -7,7 +7,6 @@ export default class GitHub { constructor(authToken: string | undefined = undefined, requireAuth: boolean = false, options: GitHubAPI.Options = {}) { this.options = merge( - { protocol: 'https' }, options, { headers: { 'user-agent': 'Electron Forge' } }, ); diff --git a/packages/publisher/github/test/github_spec.ts b/packages/publisher/github/test/github_spec.ts index a2c57a7152..ea28cfd67a 100644 --- a/packages/publisher/github/test/github_spec.ts +++ b/packages/publisher/github/test/github_spec.ts @@ -50,17 +50,12 @@ describe('GitHub', () => { it('should be able to set the Enterprise URL settings', () => { const gh = new GitHub('1234', true, { - host: 'github.example.com', - port: 8443, - pathPrefix: '/enterprise', + baseUrl: 'https://github.example.com:8443/enterprise', }); const api = gh.getGitHub(); expect((api as any).options).to.deep.equal({ - protocol: 'https', - host: 'github.example.com', - port: 8443, - pathPrefix: '/enterprise', + baseUrl: 'https://github.example.com:8443/enterprise', headers: { 'user-agent': 'Electron Forge', },