Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors js 1.4.1 has been compromised. Immediate fix is needed. #2665

Closed
3 tasks done
kyruzic opened this issue Jan 9, 2022 · 3 comments · Fixed by #2666
Closed
3 tasks done

Colors js 1.4.1 has been compromised. Immediate fix is needed. #2665

kyruzic opened this issue Jan 9, 2022 · 3 comments · Fixed by #2666
Labels

Comments

@kyruzic
Copy link
Contributor

kyruzic commented Jan 9, 2022

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version

Latest, problem a lot of earlier versions too

Electron version

13.1.1

Operating system

All

Last known working Electron Forge version

Colors-js 1.4.0

Expected behavior

When you run an electron forge command the expected output should be produced.

Actual behavior

Run any electron forge command a huge output of crap is produced.

Steps to reproduce

Run any electron forge command.

Additional information

A simple fix is needed, change colors.js to v1.4.0, I will work on a pr now. I know I didn't fill this out all correctly, but this is a total blocker for any new development.

@kyruzic kyruzic added the bug label Jan 9, 2022
@malept
Copy link
Member

malept commented Jan 9, 2022

A workaround is to pin colors in your package.json file.

@malept
Copy link
Member

malept commented Jan 9, 2022

The correct change is to replace colors with chalk. I'm not particularly interested in a PR which will pin colors in Forge's package.json files.

@kyruzic
Copy link
Contributor Author

kyruzic commented Jan 9, 2022

Okay yes, I won't do that PR then.

@electron electron locked and limited conversation to collaborators Jan 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants