You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
await got.get(parsed.toString()); should be wrapped in a try/catch and ignore if the file doesn't exist yet in S3.
Steps to reproduce
Use @electron-forge/maker-zip and macUpdateManifestBaseUrl without RELEASES.json existing in S3
Additional information
No response
The text was updated successfully, but these errors were encountered:
TranquilMarmot
changed the title
@electron-forge/maker-zip: If using macUpdateManifestBaseUrl and RELEASES.json doesn't exist, fails@electron-forge/maker-zip: If using macUpdateManifestBaseUrl and RELEASES.json doesn't exist in S3, fails
Oct 10, 2023
I'm also running into this issue, did you find a way around it @TranquilMarmot ?
Edit: looks like I figured it out, I just dropped a RELEASES.json with only {} where it should have been in S3, and it was successfully retrieved and updated.
@spaceandrew if you make an empty RELEASES.json file in S3 where electron-forge expects it to be, it should pass when publishing. You might have to put the current version in there as well, but I'm not sure. Let me know if you need more info and I can get it for you tomorrow!
@spaceandrew if you make an empty RELEASES.json file in S3 where electron-forge expects it to be, it should pass when publishing. You might have to put the current version in there as well, but I'm not sure. Let me know if you need more info and I can get it for you tomorrow!
Pre-flight checklist
Electron Forge version
6.4.2
Electron version
v26.2.4
Operating system
macOS 13.5.2 (22G91)
Last known working Electron Forge version
No response
Expected behavior
When publishing with
@electron-forge/maker-zip
andmacUpdateManifestBaseUrl
withforge.config.ts
like this:If
https://my-bucket.s3.amazonaws.com/my-app-updates/darwin/${arch}/RELEASES.json
does not yet exist, it should be created.Actual behavior
The publish fails with an error:
I believe this is happening here:
forge/packages/maker/zip/src/MakerZIP.ts
Lines 47 to 51 in 0734b02
await got.get(parsed.toString());
should be wrapped in atry
/catch
and ignore if the file doesn't exist yet in S3.Steps to reproduce
Use
@electron-forge/maker-zip
andmacUpdateManifestBaseUrl
withoutRELEASES.json
existing in S3Additional information
No response
The text was updated successfully, but these errors were encountered: