Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendly Notice to Update Electron (Post 2.0) #370

Closed
groundwater opened this issue Nov 22, 2017 · 2 comments
Closed

Friendly Notice to Update Electron (Post 2.0) #370

groundwater opened this issue Nov 22, 2017 · 2 comments

Comments

@groundwater
Copy link

Electron 2.0 will be moving to semver according to the new Versioning Policy.

The intention is that folks should be able to use proper semver ranges, either ^2.0.0 or ~2.0.0 to admit bug fixes and/or features. I know forge currently recommends locking an exact version of electron, and we hope that will not be necessary in the future.

I would propose that, for now, forge at least recommend when someone should update electron according to the following rules:

  • all rules <2.0 stay the same
  • if using a pinned version >=2.0 in package.json, recommend whenever there is a more recent patch release
  • if using any version range >=2.0 in package.json and a new major exists that is stable, recommend upgrading
@malept malept changed the title [Feature Request] Friendly Notice to Update Electron (Post 2.0) Friendly Notice to Update Electron (Post 2.0) Nov 22, 2017
@malept
Copy link
Member

malept commented Feb 13, 2018

Should this be only during electron-forge start, or when it's packaged as well? People get irritated by warnings, if the issues I've seen are any indication.

@devlsh
Copy link

devlsh commented Sep 11, 2018

@malept I think it has to be one or the other, to avoid conflicts in API. If we use >= 2.0 at runtime, we should also do so during packaging. A few issues from people who don't have/want to spend time upgrading is more than worth being both a) on semver with Electron itself and b) being up-to-date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants